Chart.js: Additional doubts on Animation documentation

Created on 24 Jul 2020  路  4Comments  路  Source: chartjs/Chart.js

Documentation Is:

  • [ ] Missing or needed
  • [ ] Confusing
  • [X] Not Sure?

Doubts

Before going to submit a PR to change the animation documentation, I need to understand better some other topics.

First of all, I have prepared a rough model to understand the relations between all animation entities.

animationModel

Hopefully it is correct

Some other doubts about the current documentation:

  1. the current table is mixing all properties for all entities, if the above design is correct.

  2. active and resize are defined as properties but they are also update modes therefore they should be removed from the table and added as default update modes where it is mentioned. Instead, if they are not update modes, they should be removed from default modes table.

  3. the to property is not mentioned even if you can use it into an animation property. Is it missing or is correctly not mentioned for any reasons?

documentation

Most helpful comment

  1. The model looks correct.
  2. active and resize are modes
  3. I don't think there is a reason for not mentioning to.

All 4 comments

  1. The model looks correct.
  2. active and resize are modes
  3. I don't think there is a reason for not mentioning to.

@kurkle thank you! I hope to submit the PR by end of next week. I'm still fighting with other stuff.

@kurkle another doubt: onProgress and onComplete callbacks are working ONLY on animation of options (no for datasets and tooltips).

Am I wrong?

You're right, only the "main" animation options

Was this page helpful?
0 / 5 - 0 ratings