Chamilo-lms: skills.php missing in Reports for HRM

Created on 21 Dec 2018  路  7Comments  路  Source: chamilo/chamilo-lms

Describe
As a human resources manager, when going to Reporting section and 'skills' gives a 'Not Found'-page.

To Reproduce
Steps to reproduce the behavior:

  1. Log in as HRM
  2. Go to 'my Reporting'
  3. Click on 'students', then on 'teacher' and then again 'students' (you are now at .../main/mySpace/student.php)
  4. as last Item there is now the button 'skills' (see screenshot)
  5. Click on this brings you to .../main/mySpaces/skills.php and the 'Not Found'-page

Expected behavior
I'm not sure. I think something like a skill overview should be shown.

Screenshots
skillsissue

Desktop (please complete the following information):

  • OS: Windows 8
  • Browse rchrome, firefox, edge

**Server

  • OS: Ubuntu 16.04
  • Version of Chamilo: 1.11.8
  • Version of PHP: 7.0.32

Additional context

Bug Requires testinvalidation

Most helpful comment

The problem from this issue is fixed, but you are wright there is something wrong in the links for the different icons, so I will open a new issue #2786 about this not to be confusing this task and I close this task. Thanks for your report and answer.

All 7 comments

Confirmed. There is a link in student.php that points to skills.php, but the only "skills.php" in the whole system is main/admin/skills.php. Not sure that's where we want the HR guy to go... We will investigate what happened.

We found a deep history going 4 years back, of an incomplete development that was dropped (but even in its incomplete form, it looks useful), so we will restore that soon.
References:

https://github.com/chamilo/chamilo-lms/commit/41380c91c313dbcbc047657c7a155aeea36d16d6

https://github.com/chamilo/chamilo-lms/commit/eaec0034a9f49af5e8eb0032d0757e42a42d9106#diff-253c27ae68fc3a8ab147fe0607c3a92c

References:

41380c9

eaec003#diff-253c27ae68fc3a8ab147fe0607c3a92c

The code in these commits exists in main/social/my_skills_report.php by this commit 3cf13a775da9d95407767735705c6d0802886381.

I'm fixing the link to my_skills_report.php

I just tested it with user ptook/ptook and following the instruction in the issue's description and I get to the page https://11.chamilo.org/main/mySpace/student.php with the Skills button and now it gets to https://11.chamilo.org/main/social/my_skills_report.php so it seems all good.

@yourKatharsis can you confirm that it is all good for you so that we can close this issue for the next release ?

He now redirects to main/social/my_skills_report.php correctly.

Not so nice: The First Click on icon "students" bring you to main/mySpace/index.php?view=drh_students&display=yourstudents .
Then click some other icon and "students" again: main/mySpace/student.php .

One icon brings you to different sites. I think that can be confusing.

@NicoDucou I think it's just a cosmetic change, so we can close that issue.

The problem from this issue is fixed, but you are wright there is something wrong in the links for the different icons, so I will open a new issue #2786 about this not to be confusing this task and I close this task. Thanks for your report and answer.

Was this page helpful?
0 / 5 - 0 ratings