Chamilo-lms: Announcements: possible to send empty title and body

[jderriks]

Current behavior / Resultado actual / Résultat actuel

Empty-title announcements can be sent. That is undesired because you cannot click the message anymore.

Expected behavior / Resultado esperado / Résultat attendu

In older versions Chamilo used to check on empty title and refude to send. That is still the expected bahaviour.

Steps to reproduce / Pasos para reproducir / Étapes pour reproduire

click create announcement icon and hit "send announcement" without entering anyting

Chamilo Version / Versión de Chamilo / Version de Chamilo

1.11.4 (git pull 24-4-2017)

[sjcqs]

I've made a fix for that bug. #1890

(cc @moy)

[jderriks]

Very good!
Maybe add the rule on the body also:
$form->addRule('content', get_lang('ThisFieldIsRequired'), 'required');

Just to prevent people forgetting entering a message.

[sjcqs]

@jderriks Maybe instead of making the body field required it would be preferable to print a warning message ?
Like when you are sending a empty mail in most of mails boxes (Gmail, etc).

[jderriks]

Sure, go ahead. It's more code.

[sjcqs]

I tried using some javascript on the validating butting but I didn't find a way to access the html editor text of content.
They must be a way since 'required' verify if a field is filled. Does anyone know where it is defined ?

[jderriks]

Content is set by:
$form->addHtmlEditor( 'content',

[jmontoyaa]

I just added a fix for the announcement description.

[jderriks]

Works.