Chakracore: build: warnning issue after updated xcode9

[tommyZZM]

OS: macOS 10.12.6
Xcode: 9.0 (just updated)
Command Line Tools (macOS Sierra version 10.12) for Xcode: 9.0

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/
usr/include/c++/v1/__undef_min_max:29:2: 
warning: : macro max is incompatible with C++.  #undefing max [-W#warnings]

many of these warning is happen on building

[dilijev]

@obastemur Can you take a look?

[obastemur]

@tommyZZM this is just a warning right?

[tommyZZM]

hi @obastemur
it seems just a warning, ch is runable after build

updated 2017-09-24 14:34 GMT+0800 (CST)

these new warnings may relate to this fatal exception of node-chakracore

https://github.com/nodejs/node-chakracore/issues/403

the node-chakracore problem disappear after I try install another Xcode 8.3.3, and rebuild only chakracore target with cc/c++ compiler in Xcode 8 toolchain.

Xcode9: Apple LLVM 9.0
Xcode8: Apple LLVM 8.1.0

| ~ | build product runable |
|:---- |:---
| node-chakracore, build all with Xcode 9 | ✕ ( fatal exception before running any code seems)
| node-chakracore, build all with Xcode 8 | ✓
| node-chakracore, build chakracore with Xcode 8 and other with Xcode 9 | ✓
| node, build all with Xcode 9 | ✓

[obastemur]

@tommyZZM Thanks for sharing this with us. The problem should be fixed on release/1.7 and (soon) master branches.