Cesium: Sandcastle web editor breaks browser search

Created on 13 May 2020  路  4Comments  路  Source: CesiumGS/cesium

Sandcastle example: pick anything with more than one page of code in your browser. I used "Polygon" for testing.

Reproduction: CTRL-F (CMD-F, etc) and search for a string. You'll find hits in the currently visible portion of the code, but nothing that you'd have to scroll down to see.

It appears as though the later content is being dynamically added and removed by the editor plugin during scrolling. If it's possible to disable this behavior, please do; if not, maybe the plugin provides its own search capability that you could hook to CTRL-F on the page? (Of course, if you felt inclined to switch to a better editor I wouldn't complain...)

Browser: Any

Operating System: Any

category - sandcastle type - bug

Most helpful comment

Sandcastle is definitely in need of a major overhaul, but I don't think we'll have the capacity to tackle it in the immediate future.

Instead of using the browser search function, use the Sandcastle search box instead:
image

This filters the demos in the gallery tab, but also highlights lines of code where that text is found in the editor.

All 4 comments

I've noticed this too and I always just instinctively copy the full text into my code editor to search..

If someone wants to look into if there's an easy fix for this I think we'd be happy to accept this contribution. I know a lot of the Sandcastle architecture is pretty old and we've talked about refactoring that a lot.

Sandcastle is definitely in need of a major overhaul, but I don't think we'll have the capacity to tackle it in the immediate future.

Instead of using the browser search function, use the Sandcastle search box instead:
image

This filters the demos in the gallery tab, but also highlights lines of code where that text is found in the editor.

Looks like Ian has a PR here with a proposed fix: https://github.com/CesiumGS/cesium/pull/8847

Fixed in #8847

Was this page helpful?
0 / 5 - 0 ratings

Related issues

puckey picture puckey  路  4Comments

mramato picture mramato  路  5Comments

mcenirm picture mcenirm  路  4Comments

GatorScott picture GatorScott  路  3Comments

worlddai picture worlddai  路  3Comments