Cert-manager: License boilerplate missing from CRDs

[vindvaki]

We would like to vendor the CRDs in another open-source project, but they are are missing the license boilerplate for the Apache 2.0 license.

I think it should be something like:

# Copyright 2020 The Jetstack cert-manager contributors.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

[munnerz]

Sure, this should be acceptable to include in the files in deploy/charts/cert-manager/crds :) would you be able to submit a pull-request? You'll need to run ./hack/update-crds.sh afterwards.

That said, could you elaborate more on why you are vendoring our CRDs into your own project? I'd strongly recommend instead pointing users to this project and installing it themselves, unless you mean as some form of "Kubernetes distribution".

[munnerz]

/area deploy
/kind cleanup
/priority backlog

[vindvaki]

Thanks @munnerz

That said, could you elaborate more on why you are vendoring our CRDs into your own project? I'd strongly recommend instead pointing users to this project and installing it themselves, unless you mean as some form of "Kubernetes distribution".

Not quite a distribution, but similar. We are building the next iteration of "GitLab Managed apps", where the configuration is stored in a git repository (as opposed to the database) and changes are applied using GitLab CI (as opposed to the rails backend).

This new approach uses helmfile to manage the charts from CI, and to simplify the management of cert-manager's CRDs, we wrap them in a local helm chart that gets installed before cert-manager. Instead of fetching the file on every pipeline that runs, we thought vendoring the file was simpler and more robust.

[munnerz]

I'm going to look into how we can automatically append a boilerplate header into our release assets, to avoid having 5 copies of the same boilerplate header in the same final files 😅

/assign

[vindvaki]

Are there many other release assets? If it's just the 00-crds.yaml, then it looks like bootstrapping the file with the license would be pretty simple. Two ideas:

1. cat the license from a central location prior to this loop
2. add a 00-license-header.yaml to deploy/charts/cert-manager/crds

[vindvaki]

I'd be happy to open an MR if it helps

[munnerz]

I've opened #2684 which should take care of this as part of our release for all manifests we publish to GitHub releases 😄