Cert-manager: Clean up certificate secret when certificate is deleted

[ssboisen]

Is your feature request related to a problem? Please describe.
When a certificate is deleted it would be nice if the secret created by it was also removed

Describe the solution you'd like
When doing kubectl delete certificate x the secret assosciated with the certificate would be removed.

Describe alternatives you've considered
Manual cleanup which is annoying

Additional context
cert manager could put an owner reference on the secret pointing to the certificate crd, then it would be cleaned up by kubernetes automatically

/kind feature

[munnerz]

819 implements this 😄

[retest-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to jetstack.
/lifecycle stale

[retest-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to jetstack.
/lifecycle rotten
/remove-lifecycle stale

[vhosakot]

I see this issue too:

$ kubectl get certs
NAME             AGE
ccp-mysql-cert   5m

$ kubectl get cert ccp-mysql-cert -o=jsonpath='{.spec.secretName}'
ccp-mysql-cert-secret

$ kubectl get secret ccp-mysql-cert-secret
NAME                    TYPE                DATA   AGE
ccp-mysql-cert-secret   kubernetes.io/tls   2      73m

# delete cert
$ kubectl delete cert ccp-mysql-cert 
certificate.certmanager.k8s.io "ccp-mysql-cert" deleted

$ kubectl get certs
NAME          AGE

# stale secret of deleted cert still exists
$ kubectl get secret ccp-mysql-cert-secret
NAME                    TYPE                DATA   AGE
ccp-mysql-cert-secret   kubernetes.io/tls   2      74m

Seeing this issue with quay.io/jetstack/cert-manager-controller:v0.5.2. Would be nice if cert-manager's cert deletes its underlying secret too so that there are no stale/old secrets.

[munnerz]

@vhosakot this was implemented in v0.6 and can be enabled with a flag #819

/close

[jetstack-bot]

@munnerz: Closing this issue.

In response to this:

@vhosakot this was implemented in v0.6 and can be enabled with a flag #819

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vhosakot]

Cool, thanks @munnerz!