Cbioportal: quick links in Plots tab

Created on 30 Sep 2019  ยท  15Comments  ยท  Source: cBioPortal/cbioportal

The following is a list of quick links. Each link should be included ONLY if the data types are available for the current query. This can be determined by looking at data source which feeds the data type dropdown of the plots tab. (both axis have the same list)

@jjgao @schultzn @adamabeshouse, would it make sense to put the plot tab parameters in the url so it's linkeable? it would actually be a bit complicated to do so because it could become stale easily, but i'm just wondering if it would be desirable?

frontend priority results.plots

Most helpful comment

So something like this?

Looks good but I would change 'Quick links' to 'Examples' or 'Example plots'.

All 15 comments

Notifying @tmazor @schultzn @cBioPortal/product

I like the idea of having examples. My main concern is how we will implement this in a way that does not clutter up the interface, which already has a considerable number of bells and whistles.

Here is a suggestion

image

@schultzn i think that works. i do think they need a label ("Quick links?"). We have Quick Filters in study page. Perhaps we can reuse the white bar under the nav. @Luke-Sikina this can be your ticket. i will work on making a more descriptive spec.

So something like this?

image

exactly. i don't think it essential, but nice to follow convention. they're also centered on study page. could go either way on this. and we don't have to decide now to start implementation.

@jjgao I think putting it in the URL would be definitely doable and wouldn't go stale so easily - we can use the data type enum, profile id, and gene id? the issue I think would be the URL would get really long..

@adamabeshouse @alisman we should look into options for storing states in url and in session service. Maybe it's time to work it out? https://github.com/cBioPortal/cbioportal/issues/5525

Maybe for this ticket here, we don't have to worry about it as long as the users can click and get to the plots? Or is it a good opportunity to make saving state happen?

@jjgao @alisman my sense is lets just focus on the feature, I think. saving state is more in depth and I think will take a while to shake out. thoughts?

@adamabeshouse that sounds good to me.

Just starting this issue. Here's my summary after reading through this.

  • create all valid quick links, as described in the main issue
  • style the quick links similar to the study page, but also refer to the mock
  • don't bother with the url for now, feature has value without it and there seems to be ongoing discussion about if / how

Please let me know if I missed anything.

So something like this?

Looks good but I would change 'Quick links' to 'Examples' or 'Example plots'.

๐Ÿ‘

On Fri, Oct 4, 2019 at 3:06 AM Sjoerd-van-Hagen notifications@github.com
wrote:

So something like this?

Looks good but I would change 'Quick links' to 'Examples' or 'Example
plots'.

โ€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cBioPortal/cbioportal/issues/6651?email_source=notifications&email_token=AABNRGPB5R37JJC7EH44DFDQM3TQFA5CNFSM4I363672YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAKWGNI#issuecomment-538272565,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABNRGKSXSISR5H3ANVTBXDQM3TQFANCNFSM4I36367Q
.

@Luke-Sikina can we try this order?

IF cancer type detailed >1 and <=15 โ†’ Mutation count vs cancer type detailed [Mut# vs Dx]
ELSIF cancer type detailed >15 โ†’ Mutation count vs cancer type [Mut# vs Dx]
IF available โ†’ Mutation count vs FGA [Mut# vs FGA]
IF mRNA & cancer type detailed >1 โ†’ mRNA vs cancer type detailed [mRNA vs Dx]
IF mRNA and mutation count > 0 โ†’ mRNA vs mutation type [mRNA vs mut type]
IF copy-number & mRNA โ†’ expression vs copy-number box plot [mRNA vs CNA]
IF methylation & mRNA โ†’ expression vs methylation scatter plot [mRNA vs methyl]
IF mRNA & protein โ†’ mRNA vs protein scatter plot [Protein vs mRNA]
IF treatments โ†’ sample order vs treatment IC50 [Tx Waterfall]

And maybe add FGA vs Cancer Type, so:

IF cancer type detailed >1 and <=15 โ†’ Mutation count vs cancer type detailed [Mut# vs Dx]
ELSIF cancer type detailed >15 โ†’ Mutation count vs cancer type [Mut# vs Dx]
IF cancer type detailed >1 and <=15 โ†’ FGA vs cancer type detailed [FGA vs Dx]
ELSIF cancer type detailed >15 โ†’ FGA vs cancer type [FGA vs Dx]
IF available โ†’ Mutation count vs FGA [Mut# vs FGA]
IF mRNA & cancer type detailed >1 โ†’ mRNA vs cancer type detailed [mRNA vs Dx]
IF mRNA and mutation count > 0 โ†’ mRNA vs mutation type [mRNA vs mut type]
IF copy-number & mRNA โ†’ expression vs copy-number box plot [mRNA vs CNA]
IF methylation & mRNA โ†’ expression vs methylation scatter plot [mRNA vs methyl]
IF mRNA & protein โ†’ mRNA vs protein scatter plot [Protein vs mRNA]
IF treatments โ†’ sample order vs treatment IC50 [Tx Waterfall]

Was this page helpful?
0 / 5 - 0 ratings