Cbioportal: an ampersand gets added to the end of URLs and breaks them

Created on 19 Oct 2017  路  3Comments  路  Source: cBioPortal/cbioportal

If you right click on a tab and load it in a new window, you get a URL specific to that tab -- for example http://www.cbioportal.org/index.do?session_id=59690649498e5df2e292870c&show_samples=false&clinicallist=AGE&#mutex will go directly to the Mutual Exclusivity tab.

However, during the process of the page loading, an ampersand gets added to the end of the URL (http://www.cbioportal.org/index.do?session_id=59690649498e5df2e292870c&show_samples=false&clinicallist=AGE&#mutex&). This link with the ampersand no longer works as a direct link to Mutual Exclusivity and will default back to loading OncoPrint. So if you click the first link and then reload the page (or wait until after it finished loading to copy the link), you end up at the OncoPrint tab.

Why does that ampersand get added? Can we get rid of it?

bug frontend

Most helpful comment

yes this will be fixed in the refactor. I'm going to handle the URL parameters in a much less hacky way that will fix this.

All 3 comments

@adamabeshouse Could you fix this during oncoprint tab refactoring?

I am also thinking of removing all the status (&show_samples=false&clinicallist=AGE) in the url and put it into the session. Every time the user click on the bookmark/twitter/session icon, a new session should be generated. @Tamba32 @alisman

yes this will be fixed in the refactor. I'm going to handle the URL parameters in a much less hacky way that will fix this.

fixed by refactor, merged into rc

Was this page helpful?
0 / 5 - 0 ratings

Related issues

pieterlukasse picture pieterlukasse  路  13Comments

ecerami picture ecerami  路  8Comments

fedde-s picture fedde-s  路  8Comments

inodb picture inodb  路  8Comments

ChandraPedamallu picture ChandraPedamallu  路  3Comments