Cb-tumblebug: Adopt Structure Validation

[jihoon-seo]

Ref:

• https://blog.billo.io/devposts/go_struct_validation/
• https://genius-kim-1047.tistory.com/59
• ...

What would you like to be enhanced
:
Adopt Structure Validation

Why is this needed
:

Proposed solution
:

[jihoon-seo]

• https://blog.billo.io/devposts/go_struct_validation/
  
  
  
  • https://github.com/go-ozzo/ozzo-validation (MIT license, 2.3k stars, 144 forks)
    
    각 struct에 대한 Validate() 함수를 작성하는 방식
  
  
  • https://github.com/go-playground/validator (MIT license, 8.6k stars, 764 forks)
    
    struct tag를 활용하는 방식
  
  
  • https://github.com/asaskevich/govalidator (MIT license, 4.9k stars, 490 forks)
    
    struct tag를 활용하는 방식
  
  
  • https://github.com/go-validator/validator (Apache 2 license, 1.2k, 121 forks)
    
    struct tag를 활용하는 방식
  
  

---

• https://echo.labstack.com/guide/request/#validate-data
  Echo를 사용할 때, go-playground/validator를 활용하는 예시
• Request validation with Golang Echo
  https://www.darc-scrum.com/takumi/en/golang-validation/

[seokho-son]

@jihoon-seo 하나가 강조되어 있네요.. ? ㅋㅋ

[seokho-son]

https://echo.labstack.com/guide/request/#validate-data
Echo를 사용할 때, go-playground/validator를 활용하는 예시

좋네요.. ^^

[seokho-son]

/assign @jihoon-seo

[jihoon-seo]

[적용 현황]

• image: https://github.com/cloud-barista/cb-tumblebug/blob/9c8b00900e354a3f1134b2c4d461bae1347255ba/src/core/mcir/image.go#L131
• SG: https://github.com/cloud-barista/cb-tumblebug/blob/9c8b00900e354a3f1134b2c4d461bae1347255ba/src/core/mcir/securitygroup.go#L142
• spec: https://github.com/cloud-barista/cb-tumblebug/blob/9c8b00900e354a3f1134b2c4d461bae1347255ba/src/core/mcir/spec.go#L398
• SSH key: https://github.com/cloud-barista/cb-tumblebug/blob/9c8b00900e354a3f1134b2c4d461bae1347255ba/src/core/mcir/sshkey.go#L132
• vNet: https://github.com/cloud-barista/cb-tumblebug/blob/9c8b00900e354a3f1134b2c4d461bae1347255ba/src/core/mcir/vnet.go#L160
• subnet: https://github.com/cloud-barista/cb-tumblebug/blob/9c8b00900e354a3f1134b2c4d461bae1347255ba/src/core/mcir/subnet.go#L47

---

• MCIS:
  
  
  
  • https://github.com/cloud-barista/cb-tumblebug/blob/9c8b00900e354a3f1134b2c4d461bae1347255ba/src/core/mcis/provisioning.go#L517
  
  
  • https://github.com/cloud-barista/cb-tumblebug/blob/9c8b00900e354a3f1134b2c4d461bae1347255ba/src/core/mcis/provisioning.go#L705
  
  

일단은 모든 자원에 대해 적용되어 있는 것으로 보입니다. 😊

[seokho-son]

그럼 close 하겠습니다!!