Cats: `MonadTests[M].stackUnsafeMonad` overflows - `MonadLaws.tailRecMStackSafety` should be a def

Created on 10 Nov 2016  路  3Comments  路  Source: typelevel/cats

MonadLaws.tailRecMStackSafety is currently a val; this means MonadTests[M].stackUnsafeMonad checks for stack safety anyway as soon as the MonadLaws[M] instance is created

picture TrustNoOne

Most helpful comment

Good catch! I think a lazy val might be best but a def would work too.

picture non on 10 Nov 2016
👍3

All 3 comments

Good catch! I think a lazy val might be best but a def would work too.

non picture non on 10 Nov 2016
👍3

We should also look into testing stackUnsafeMonad by changing MonadTestsTests to use a stack-unsafe monad.

edmundnoble picture edmundnoble on 10 Nov 2016

Ugh, I think this must have been my fault. Thanks for catching it, @TrustNoOne.

travisbrown picture travisbrown on 10 Nov 2016
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

davidabrahams picture davidabrahams  路  3Comments
non picture non  路  3Comments
fosskers picture fosskers  路  3Comments
kailuowang picture kailuowang  路  5Comments
julien-truffaut picture julien-truffaut  路  3Comments