Cataclysm-dda: Toolboxes increase their volume as you put tools into them [non-rigid container behavior?]

[DeltaEpsilon7787]

Describe the bug

The base volume of a toolbox is 2.5L. It has a pocket of 2.4L.
As you put stuff into the toolbox, the overall volume of the toolbox increases instead of staying at 2.5L.

Steps To Reproduce

Craft a toolbox.

Notice it has 2.5L of volume

Put a 1.0L tool into it.

The volume of the toolbox is 3.5L now.

Expected behavior

Volume should stay at 2.5L. Only weight increases.

Screenshots

Versions and configuration

• OS: Windows


• OS Version: 10.0 1909


• Game Version: 0.E-5241-g89c6d05 [64-bit]


• Graphics Version: Tiles


• Game Language: System language []


• Mods loaded: [
  
  Dark Days Ahead [dda],
  
  Disable NPC Needs [no_npc_food]
  
  ]

Additional context

N/A

[EvgenijM86]

I think new toolboxes are kinda useless. They don't decrease used volume and they don't decrease inventory clutter. The old toolbox did both - it occupied less volume than similar separate tools (1) and it displayed as a single item, reducing inventory clutter. You might as well just store tools directly in your backpack. But if you really want a separate container for all your tools for some reason a plastic bag is a much better choice, because it has 6L max volume (more than double of toolbox) and it's occupies only as much space as you put inside of it.

1 - which could be realistic, because tools in the toolbox could be shorter in size - not every tool has to be identical

[anothersimulacrum]

When it's both made from and can be turned into separate components that are larger than it, it doesn't make sense, that's a bug, not something that you can explain away.

[EvgenijM86]

It makes sense. For example: you have a hacksaw that occupies some volume, but has a big hole inside of it - you can place a flat items inside that hole, and as long as container hold them in that position they will occupy less space than if you just summed up their individual volumes.

[Hulkninja]

When it's both made from and can be turned into separate components that are larger than it, it doesn't make sense, that's a bug, not something that you can explain away.

Soooo just adjust the total volume and weight to be more accurate, instead of making toolboxes useless..?
Like, what purpose do they currently serve in the game? Why should I keep my tools in a toolbox instead of in my backpack/pockets, when that toolbox will most likely just end up in my backpack anyhow?

It makes sense. For example: you have a hacksaw that occupies some volume, but has a big hole inside of it - you can place a flat items inside that hole, and as long as container hold them in that position they will occupy less space than if you just summed up their individual volumes.

I was thinking sort of the same thing. Efficient storage is one of the key aspects of real-life toolboxes. Like, the total weight is obviously never lower than the tools in it, and it has to be at least as long as the longest side of the longest tool it contains, but the volume it takes up could potentially be a bit lower.

Either way, toolboxes are currently a totally useless item, they do the same thing as wearable storage, only worse, because they can't be worn. By the time you have a toolbox, you're usually already equipped with enough storage to store most, if not all, the tools you need.

[DeltaEpsilon7787]

@Hulkninja

Why should I keep my tools in a toolbox instead of in my backpack/pockets, when that toolbox will most likely just end up in my backpack anyhow?

For context: the only reason why I made two those toolboxes is for convenience. I play a melee character that doesn't always need to keep all of his tools with him and needs to keep his encumbrance as low as possible, so, utilizing the half-broken pocket system, I wanted to just store them in a container so I could easily chuck it into a shopping cart trunk when I'm going raiding.

As I collect loot, I also come across tons of other tools and stuff.

When I'm done, I can just pick up the toolbox without having to sort through my loot and find my tools again. Frankly, I could just mark them with a permanent marker, but eh, I decided to try out newer systems.

Well, thanks to this bug, I changed to a duffel bag instead.

--

Additionally, there is actually a toolbox that works like you described: 2.5L, but contains most necessary tools: workshop toolbox. However, those require two unusual components: a pin reamer and a clamp, which can't be crafted.

[EvgenijM86]

@Hulkninja
As a melee character you would want to drop you backpack on the ground anyway before engaging in melee, so encumbrance of those tools does not factor in when actual combat is happening. It affects both your dodge and melee rolls, and the worst part of having backpack in melee is that enemies can shred it to pieces and a lot of your stuff will drop on the ground.

[esotericist]

it looks like as of #43187 this should be resolved, it just didn't get automatically closed when the fix was merged.