Cataclysm-dda: Cant shoot through chain fences

Created on 13 Apr 2020  路  4Comments  路  Source: CleverRaven/Cataclysm-DDA

Describe the bug

Unable to shoot through chain fences

Bullets do not travel through chain fence to hit target, they just disappear.

Steps To Reproduce

  1. Aim at a zombie on other side of a fence
  2. Fire at target
  3. Bullet disappears, target uninjured

Expected behavior

Able to shoot through fences

Target is hit with bullet

Screenshots

Versions and configuration

Additional context

<Bug> Fields / Furniture / Terrain / Traps Ranged

Most helpful comment

If that wasn't clear, I'm working on this issue.

All 4 comments

Probably resurface of #22814.

Could be related to #37329 and #38882

Well I can confirm metal bars are affected too. Latest experimental 0.E-635-gef0197a.

Yep, my fault
c663dfdc523e56ae1d522f7585de616c02c09631 is the first bad commit

commit c663dfdc523e56ae1d522f7585de616c02c09631
Author: anothersimulacrum <[email protected]>
Date:   Thu Apr 9 00:09:19 2020 -0700

    Add assign reader for damage instances, deprecate legacy damage code (#37329)

    * Add assign reader for damage instances

    This assign reader allows consistent and clear reading of damage
    instances for all items.

    Make the necessary changes to item factory and damage units to preserve
    existing functionality.

    * Cleanup damage parameter names

    These names weren't very clear, hopefully this is an improvement.

    The JSON changes are to fix errors this exposes.

 data/json/items/gunmod/muzzle.json              |   1 -
 data/mods/Dark-Skies-Above/monsters/mongun.json |   3 +-
 src/assign.h                                    | 282 ++++++++++++++++++++++++
 src/creature.cpp                                |   2 +-
 src/damage.cpp                                  | 102 +++++++--
 src/damage.h                                    |  19 +-
 src/dump.cpp                                    |   1 -
 src/game_inventory.cpp                          |   5 +-
 src/item.cpp                                    |  41 ++--
 src/item_factory.cpp                            |  42 +---
 src/itype.h                                     |  12 -
 src/player.cpp                                  |  11 +-
 12 files changed, 413 insertions(+), 108 deletions(-)

If that wasn't clear, I'm working on this issue.

Was this page helpful?
0 / 5 - 0 ratings