Cataclysm-dda: "You can't crack a safe with earbuds on!"

[GGgatherer]

Describe the bug

Needless to say, I don't even have earbuds. I do have the stethoscope though.
e: also, sound dampening is off. also, survivor helmet isn't the culprit.

Steps To Reproduce

Load save, try cracking any of 4 safes, get the message.

Expected behavior

Being able to crack the safe without getting obviously wrong message.

Screenshots

Versions and configuration

OS: Windows 7x64
Game Version: 0.D-12235-g3a8c5fb [64-bit]
Graphics Version: Tiles
Mods loaded: [
Dark Days Ahead [dda],
Disable NPC Needs [no_npc_food],
Modular Turrets [modular_turrets],
Salvaged Robots [Salvaged_Robots],
Alternative Map Key [alt_map_key],
sees-player icon, retrodays [sees_player_retro],
Stats Through Skills [StatsThroughSkills]
]

[anothersimulacrum]

Do you have an active mp3 player?

[wapcaplet]

This message is from my fix for #36013 but you shouldn’t be seeing it without an mp3 player (or smartphone with music) on.

Edit: I loaded up your savegame - your character does have an active mp3 player on. Perhaps the message could be clearer, but since it says "You put in the earbuds" when you start listening to music, I chose the same word (instead of specifically referring to an mp3 player, because it could also be a smartphone).

What if instead it said "You can't crack a safe while listening to music"? Or even "You can't use a stethoscope and earbuds at the same time"? (to future-proof it against, I dunno, audiobooks, or post-apocalypse talk-radio)

[JeanLucVanDamme]

Those last two options sound better for explaining the conflict.

Another option, why not include the conflicting device in the message? "You can't crack a safe with earbuds on! (mp3 player - active)". Something like that, I'm sure there's a cleaner way to say it. Make the device name a different color to emphasize that it's the important part, and a variable, in the message.

[wapcaplet]

@JeanLucVanDamme I like the idea of indicating which device is active, but unfortunately it looks like I'd need to clutter the safe-cracking code with the same multiple device IDs we already have in the mp3 on/off functions.

I have submitted a PR #38003 that changes the message to "You can't crack a safe while listening to music!" - I hope this is a satisfactory fix.

[GGgatherer]

I loaded up your savegame - your character does have an active mp3 player on. Perhaps the message could be clearer

Actually, that's more like my fault. Non-native English speaker here, so while I was reading (and later writing) earbuds, what I was actually thinking of was earplugs, which is an actual in-game wearable item which my character didn't have. :facepalm.bmp:, I guess.
Nevertheless, I agree the message about listening to music will explain the situation much clearer.