Cataclysm-dda: Wrap up loose ends for new alcohols from #35164
Summary
To properly "finish" #35164, the following things should be done (see the PR for more details):
- Add inheritance to the new alcohols as I pointed out in a review.
- Capitalize proper nouns in the item names, and remove references to specific containers as pointed out by @Kodiologist.
- Add the new alcohols to recipes, and
cooking_components.jsonlists, as pointed out by @Jovus.
Davi-DeGanne
👍1
All 2 comments
This looks like a good project for a new contributor who wants to get his feet wet with only very slightly more complicated JSONs, and who wants to figure out how to link PRs and Issues through Github. (That's me volunteering but noncommitally, and not before January due to travel.)
Jovus
on 9 Dec 2019
❤2
This looks like a good project for a new contributor who wants to get his feet wet with only very slightly more complicated JSONs, and who wants to figure out how to link PRs and Issues through Github.
Nah, this is mine. 馃槇
LaVeyanFiend
on 13 Dec 2019
😄1
Was this page helpful?
0 / 5 - 0 ratings
Related issues
ituluwituluwzev
路
3Comments
natsirt721
路
3Comments
Asmageddon
路
3Comments
Taberone
路
3Comments
tinukedaya
路
3Comments
Most helpful comment
This looks like a good project for a new contributor who wants to get his feet wet with only very slightly more complicated JSONs, and who wants to figure out how to link PRs and Issues through Github. (That's me volunteering but noncommitally, and not before January due to travel.)