Cataclysm-dda: Character get sent back in time on load.

[GitGodScrub]

Describe the bug

The date gets messed up, when loading in an game from Build #9112.

Expected behavior

The date is way off, i think it has reverted to Spring/jumped forward to next Spring.
I think that

Screenshots

Before:

After:

Versions and configuration

(Non-updated version)

• OS: Windows
  
  
  
  • OS Version: 10.0 1803
  
  
• Game Version: 0.D-4039-g02eaddf [64-bit]
• Graphics Version: Tiles
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  Bootleg Walkers [Bootleg_Walkers],
  Modular Turrets [modular_turrets],
  Salvaged Robots [Salvaged_Robots],
  Alternative Map Key [alt_map_key],
  Mining Mod [Mining_Mod],
  Beta National Guard Camp [national_guard_camp],
  Dorf Life [Dorf_Life],
  Arcana and Magic Items [Arcana],
  Magiclysm [magiclysm],
  Necromancy [necromancy],
  Manual Bionic Installation [manualbionicinstall],
  Prevent Zombie Revivication [no_reviving_zombies]
  ]

Additional context

I think that it is because of https://github.com/CleverRaven/Cataclysm-DDA/pull/30253 .
Season length is set to 14.
Start date was Spring 1

I am not quite sure how the date is calculated, but here is my guess:
Before:
1 day = 24*60*(60/6) = ‭14400‬ ticks
Now:
1 day = 24*60*(60/1) = 86400 ticks
Difference:
+72000‬ ticks

Spring day 1 -> Autumn day 10 = ‭38‬ days
Before:
38‬ days = 547,200 ticks
Now:
38‬ days = 3,283,200 ticks
Difference:
+2,736,000 ticks

Now, since the game know that the "date" is 547,200 ticks, that is equal to 6.3 days, according to the new date-system.
That means that the date is now:
Spring 7

Save from Build #9112:
Clemson.zip

[kevingranade]

I need to do some testing but we can probably just roll the calendar forward for people suffering from this problem. The main thing I need to check for is that we don't advance rot or zombie mutation by doing so, as far as I know you're currently counting as being behind where you're expected to be so that should be fine.

[kevingranade]

For 0.E, we need to verify whether migrating a save from 0.D to 0.E causes this problem, if it does we need to apply the fix, but if there is just some span of experimental releases that are affected, fixing it would do more harm than good.

[KorGgenT]

so i started a save on summer 1 with standard season lengths and waited a few days. then i moved the save to most recent master and got the following: