Cataclysm-dda: Collect Firewood doesn't repeat

Created on 2 Mar 2019  路  1Comment  路  Source: CleverRaven/Cataclysm-DDA

Describe the bug
In the description for Collect firewood, it says that it is a 3 hour interval repeated action, which implies that it would be like Gather Materials. However, it only gathers for the first 3 hours before being "Done".

To Reproduce
Steps to reproduce the behavior:

  1. Go to camp manager.
  2. Send a companion on both firewood and material gather duties.
  3. Wait 3 or more in-game hours.
  4. Look at results.

Expected behavior
I expected it to be repeatedly gathering material at the intervals noted in the portion of the notes.

Screenshots
image
image
image

Versions and configuration(please complete the following information):

  • OS: [Windows 10]
  • Game Version: [0.C-37564-g412ee85]
  • Graphics version: [Tiles]
(S2 - Confirmed) <Bug> Player Faction Base / Camp [C++]

Most helpful comment

Here's the fix:

diff --git a/src/faction_camp.cpp b/src/faction_camp.cpp
index 075e951ae9..8959438a63 100644
--- a/src/faction_camp.cpp
+++ b/src/faction_camp.cpp
@@ -401,7 +401,7 @@ void talk_function::camp_missions( mission_data &mission_key, npc &p )
                                npc_list.size() < 3 );
         if( !npc_list.empty() ) {
             entry = _( "Searching for firewood.\n" );
-            bool avail = update_time_left( entry, npc_list );
+            bool avail = update_time_fixed( entry, npc_list );
             mission_key.add_return( "Recover Firewood Gatherers",
                                     _( "Recover Firewood Gatherers" ), "", entry, avail );
         }

will submit it after the post 0.D backlog clears.

>All comments

Here's the fix:

diff --git a/src/faction_camp.cpp b/src/faction_camp.cpp
index 075e951ae9..8959438a63 100644
--- a/src/faction_camp.cpp
+++ b/src/faction_camp.cpp
@@ -401,7 +401,7 @@ void talk_function::camp_missions( mission_data &mission_key, npc &p )
                                npc_list.size() < 3 );
         if( !npc_list.empty() ) {
             entry = _( "Searching for firewood.\n" );
-            bool avail = update_time_left( entry, npc_list );
+            bool avail = update_time_fixed( entry, npc_list );
             mission_key.add_return( "Recover Firewood Gatherers",
                                     _( "Recover Firewood Gatherers" ), "", entry, avail );
         }

will submit it after the post 0.D backlog clears.

Was this page helpful?
0 / 5 - 0 ratings