Cataclysm-dda: Prying crates opens a menu even if you only have 1 item with pry quality

[EyesNoEyes]

Describe the bug
https://i.imgur.com/10P4hTD.png

To Reproduce
Try to pry open a crate with a single prying item

Expected behavior
It should just pop open without a needless additional menu

Screenshots
https://i.imgur.com/10P4hTD.png

[curstwist]

Ideally, it'd be nice for it to auto-choose even if you have multiple tools. I don't really care if my crowbar or halligan bar does the job.

[EyesNoEyes]

I just noticed, even if you select "leave it alone" it automatically pries it anyway. So the menu is even _more_ useless

[curstwist]

note: EyesNoEyes comment that it prise automatically is 1/2 right. Sometimes it does & sometimes it doesn't. I haven't been able to pin down conditions for each yet.

[ThinkInvis]

It's set up to pry automatically if the player _only has one prying tool_, but then it doesn't stop the examine* action there (missing return) so it continues on to show the selection menu.

I tried to fix this issue in a personal fork a few days ago, and in doing so I added two entries to the options section: "auto-pry crates on examine" and "auto-pry locks on examine". I only got back into working on the C++ side of C:DDA a few days ago, after a long break, and I'm not sure what the stance is on adding new options to the official game -- would it be better to choose one behavior or the other (always auto-use best, or always ask) and make it the only one instead?

Ideally, it'd be nice for it to auto-choose even if you have multiple tools. I don't really care if my crowbar or halligan bar does the job.

The "which prying tool to use" prompt could be useful if, as a comment in the pry code notes, some kind of charge-eating power prying tool is introduced later... or possibly crowbars being damaged on use/fail, like with bashing with a wielded item? Anything that changes the state of a prying tool when the player uses it could be undesirable in some situations. Also, the code for examining locked doors only allows prying right now, but it might be possible to deliver a choice between prying and lockpicking in the prompt (which definitely makes it useful, due to the chance of damaging lockpicks on fail).

[EyesNoEyes]

note: EyesNoEyes comment that it prise automatically is 1/2 right. Sometimes it does & sometimes it doesn't. I haven't been able to pin down conditions for each yet.

It only happens if you only have one tool and hit 'leave it alone'. If you have two tools it leaves it alone.

[Denniz-Dal]

If you have a crowbar or hallagen in a toolbelt, it shows up as an extra option on the pry list. (i.e. the toolbelt AND the bar.) Two points if you can guess which one gets defaulted. ;)