Cataclysm-dda: Negative damage for firearms

[Night-Pryanik]

Game version: 0.C-8263

Operating system: Windows 10 x64

Tiles or curses: tiles

Mods active: default only

Expected behavior

Firing ammo with negative damage should heal monsters instead of damaging them?

I guess we should either cap the negative values even for damaged firearms to 0 or change the formula so the negative values should never appear - either way it should eliminate confusion for players.

[Lorith]

This causes other issues as well, even at zero, though apparently it is 'not a bug' since it only shows up while modding

[Firestorm01X2]

I don't understand where -19 coming from.

GUN:

"id": "hk_ucp",
"ranged_damage": -1,

AMMO:
"id": "46mm",
"damage": 18,

It should give -1+18=+17

Right?

[Lorith]

Ah, right, I was wrong, this can occur in basegame via weapon damage, as shown above. Take your gun and smash it into a wall repeatedly until it is damaged, or run it over with a car a few times, and you will get a large negative damage on the gun.

[JoeTheHobo1]

Imagine actually being Kevin looking at this now, after being a smug dick when it was first reported.

[JoeTheHobo1]

Easy now on what? Pointing out how the person in charge of the game is smug for no deserved reason, and then it immediately came back to spit in his face? Did I miss something here, or are people who's job it is to code and maintain code not supposed to actually investigate issues and do their due diligence, rather than just go 'lol you're just a modder' and close bug reports without even attempting to look into things?

[JoeTheHobo1]

So, let me get this straight here. Everyone knows that Kevin is an asshole, doesn't listen to feedback, and that any attempt to change that will just make him get angry and dig in worse. And for some reason, everyone just keeps going along with this, rather than just ignoring him entirely like he deserves, and going off to make a fork of the project. And that you actually support this, because... I honestly don't know a reason that you'd support it, so please, I'm curious. Why should the community not just give him the boot?

[JoeTheHobo1]

That's what you just said, though.

[Night-Pryanik]

@JoeTheHobo1 Please stop talking some about something that's not related to the issue itself.

[JoeTheHobo1]

Given that it directly relates to the issue being ignored by the person in charge of the project, and subsequently coming up again, it is indeed related to the issue itself.

[Zireael07]

I am not seeing any posts from Kevin, so your comments about Kevin being smug are completely unwarranted.

[JoeTheHobo1]

I am not seeing any posts from Kevin, so your comments about Kevin being smug are completely unwarranted.

See the second post, then, for the link to the original issue.

[Zireael07]

@JoeTheHobo1: That other issue is admittedly related (caused by negative damage), but "modding causes weird stuff to happen" is a completely valid reply. Here we have clear steps how to reproduce the negative damage without any modding at all, so hopefully someone actually skilled in c++ comes along with a fix.

[ZhilkinSerg]

Easy now on what? Pointing out how the person in charge of the game is smug for no deserved reason, and then it immediately came back to spit in his face? Did I miss something here, or are people who's job it is to code and maintain code not supposed to actually investigate issues and do their due diligence, rather than just go 'lol you're just a modder' and close bug reports without even attempting to look into things?

The thing is nobody owes nobody anything here, so you may just breathe out and chill.

[I-am-Erk]

Until now it was only a bug shown through modding. Bugs that show up by modding things out of range aren't bugs, if we focused our efforts into making code so robust it couldn't even be modded to break, we'd never solve actual bugs.

Someone has now shown that the same problem comes up in niche areas of regular play. Now it is a bug.

This isn't rocket science.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

[stale[bot]]

This issue has been automatically closed due to lack of activity. This does not mean that we do not value the issue. Feel free to request that it be re-opened if you are going to actively work on it