Cataclysm-dda: Survivor utility belt with holstered item is not considered as a `cutting_wire_standard` in crafting

Created on 8 Oct 2018  路  3Comments  路  Source: CleverRaven/Cataclysm-DDA

When trying to craft an item that requires cutting_wire_standard, like bike basket, or wire basket, I found that survivor utility belt doesn't satisfy aforementioned requirement.
It appears that survivor utility belt only works if it doesn't have any item holstered.

To Reproduce

  1. Wish for survivor utility belt and butcher knife
  2. Unlock all recipes
  3. Open craft menu and search for wire basket or bike basket
  4. Verify that survivor utility belt in the requirements list is green
  5. Holster butcher knife in survivor utility belt
  6. Open craft menu again and search for wire basket or bike basket
  7. Verify that survivor utility belt in the requirements list is now red

Expected behavior
survivor utility belt should provide cutting_wire_standard capability regardless of whether it contains holstered item or not.

Screenshots
image

image

image

Versions and configuration(please complete the following information):

  • MacOS
  • Game Version [from the main menu, e.g. 0.C-29938-g90f5268437]
    image
  • Graphics version: Tiles
  • Mods loaded:
    image
    image
    image

Additional context
Seems that cutting_wire_standard is not a regular item quality, but rather something external, specified in toolsets.json. Probably the issue is in the logic that checks the requirements resolved via toolsets.json.

(S2 - Confirmed) <Bug> Crafting / Construction / Recipes Good First Issue Items / Item Actions / Item Qualities

Most helpful comment

Seems that cutting_wire_standard is not a regular item quality, but rather something external, specified in toolsets.json. Probably the issue is in the logic that checks the requirements resolved via toolsets.json.

Both cutting_wire_standard and welding_standard are correctly expanded into qualities and tools, as evidenced by first screenshot of crafting UI; no problem there.

The issue arises due to the check here -- with a knife sheathed in it, the belt has non-empty contents and becomes ineligible for use as a crafting component. (But we're using it as a tool.)

Working on a fix.

All 3 comments

Also, the new mechanics means you have to get out the shovel to use if on a belt. :p
But I guess that is as intended, where as this is a bug.

Seems that cutting_wire_standard is not a regular item quality, but rather something external, specified in toolsets.json. Probably the issue is in the logic that checks the requirements resolved via toolsets.json.

Both cutting_wire_standard and welding_standard are correctly expanded into qualities and tools, as evidenced by first screenshot of crafting UI; no problem there.

The issue arises due to the check here -- with a knife sheathed in it, the belt has non-empty contents and becomes ineligible for use as a crafting component. (But we're using it as a tool.)

Working on a fix.

it's the folding wire basket that requires specific tools, instead of a tool quality?

Was this page helpful?
0 / 5 - 0 ratings

Related issues

RogueYun picture RogueYun  路  3Comments

2birdie picture 2birdie  路  3Comments

BorkBorkGoesTheCode picture BorkBorkGoesTheCode  路  3Comments

jeremyshannon picture jeremyshannon  路  3Comments

Coolthulhu picture Coolthulhu  路  3Comments