Cataclysm-dda: Rotten food can be used in non-perishable recipes to make non rotten food.

[Treah]

Game version: current

Operating system: any

Tiles or curses: any

Mods active: none

Expected behavior

Only foods that allow rotten food should allow rotten food.

Actual behavior

Any recipe can be used with rotten food but only the end product is rotten if the end product is perishable.

Steps to reproduce the behavior

Get some rotten meat and make dehydrated meat. Then re-hydrate the meat. Its suddenly no longer rotten.

Suggest creating a check in code that will warn the player if they are going to be using rotten food for the recipe for foods that will produce a rotten result and block foods that would allow the player to exploit this to make non rotten from rotten food. Suggest a Json flag that can be checked if the recipe allows rotten food. The fish bait is a good example where it should be allowed to use rotten food. Maybe ALLOW_ROTTEN or on foods that it shouldn't be allowed a NO_ROTTEN flag.

[Leland]

Very, very old bug. Note that there's plenty of reasons for people to craft using rotten components, see https://github.com/CleverRaven/Cataclysm-DDA/pull/19562#issuecomment-263901947.

Additionally, see #20210 for a possible improvement that would allow addressing this.

[Treah]

Hmm I see what you mean Leland. I think this problem is covered under the suggestion from Cool. I can close this then.

[Night-Pryanik]

Why reopening? The reasons stated in #19562 ain't valid?

[kevingranade]

It doesnt matter how hard it is to fix it, bugs should be tracked
indefinitely until there is a fix.

[ifreund]

I think that blacklisting rotten ingredients when crafting non-perishables would be an appropriate fix here. Should be able to accomplish it without new flags and json work hopefully with the help of #28114.