Cataclysm-dda: Bandages aren't consumed when used

[sick-trigger]

Using bandages to heal or stop bleeding doesn't actually use up a bandage. First aid kits aren't affected. Probably came from https://github.com/CleverRaven/Cataclysm-DDA/pull/18681

[CoroNaut]

I can confirm it happens in build 6132.

[jedibob5]

Neither does taking aspirin, on my end.

[keyspace]

Ran a few tests manually, good candidate for unit automated testing.

item|type|contained|[E]ating|[a]ctivating
-|-|-|-|-
waterskin with mineral water|food|yes|ok|ok
peanut butter candy|food|no|ok|ok
plastic bag of peanut butter candies|food|yes|ok|ok
first aid kit|med|no|can't (as expected)|ok
bandage|med|no|ok|not consumed (bug)
cigarette|med|no|ok|not consumed (bug)
pack with cigarettes|med|yes|ok|can't (bug)

Ping @codemime

Haven't bisected to #18681 exactly, but appeared around time of merge.

---

EDIT: Suspect to affect all meds.

[AncientSion]

tried aspirin, poppy painkiller and poppy sleep as well as bandage, no charges used.

[codemime]

Will fix.

[pisskop]

Gin quantity was not consumed when I used it.

[keyspace]

Anecdotal (haven't tested), but Chesthole on IRC has mentioned that:

When you use ... heroin ..., it does not consume a charge.
Nor does it ever effect you negatively.
I did 40 heroin, and it is the waiting that kills you apparently.

[keyspace]

Seems that the [a]ctivate ("Use item") menu doesn't call have player::consume_item() EDIT1: in its code pathway.

---

EDIT1: I'll do a bisect to verify it's _really_ #18681. :/ EDIT3: Yes.

5e078c89cd34c1c152a8571764b51651d4556e77 is the culprit. a9f745819221d4f4d932addb22bcef7980cf71ce and 969b2dc775e4c609e2396c878252e5eb295fa1fe (respectively 3 and 1 commits earlier) don't have "can't activate" bug, but give a debugmsg:

Unknown comestible type of item: cigarette (both from pack and not)

EDIT4: a matchbook charge is consumed, though.

EDIT5: I can no longer edit the table above to include a "uses tool" column. Guess Github thinks "enough is enough".

[Chezzo]

I was incorrect, @Keyspace-1.

On Sat, Jan 14, 2017 at 8:30 AM, Keyspace-1 [e-mail]
wrote:

Seems that the [a]ctivate ("Use item") menu doesn't call
player::consume_item().

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/CleverRaven/Cataclysm-DDA/issues/20006#issuecomment-272624304,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACUcsYFzzlQwgBXfL5HlPDO3YWv0ejUpks5rSM4FgaJpZM4LgImJ
.

--
Sean Osman
215-450-7997

[keyspace]

@codemime sorry to ping again, comment above was edited with bisect results. EDIT: and they're weird.

---

EDIT2:

I was incorrect, @Keyspace-1.

No, you were. [A]ctivating a cigarette (compared to [e]ating) doesn't give the effects (Lit up, Nicotine and Stimulant) on current master. (EDIT3: it does on 969b2dc.) See comment above.

[codemime]

@keyspace I'd appreciate if you test the fix.

[AncientSion]

Yay, a fix. This one stands really out as a huge issue, because basicly you need to keep of track and manually drop the items you have...used,.
Itherwise you are potentially cheating. Hope this fix is live soon as well as..working ;)
good luck,

[bpwatts]

Hydrogen Peroxide has the same issue... can have unlimited uses if found -- but it was also not available to use except from the '%' menu. I could not [a]pply it as I could a bandage.

[codemime]

This should be possible with the fix applied.

[keyspace]

Note: build 6126 is the one before the breaking changes.

[jedibob5]

Has this not been fixed yet? If the bug is this difficult to correct, shouldn't we revert the commit that originated it and reintroduce whatever feature it was trying to implement once it can be done correctly? It's a pretty serious issue to be leaving on master for this long.