Cataclysm-dda: Any thoughts on updating the mshock32 tileset?

[Regularitee]

There's a neat little mod called "ottoplus" ( http://smf.cataclysmdda.com/index.php?topic=12029.30 ) which is pretty identical to the mshock32 tileset, but adds very high detail character sprites (individual mutations and gear are visible). Another forum member and I also creating a compatibility patch for mshock32 to add mobs from the PK's rebalancing mob.

These are all improvements which don't remove anything, so should be okay. But I wanted to inform folks and give a chance to lodge concerns or objections before I went ahead and changed it without warning. I wasn't sure how people would feel about mucking about in the tilesets.

[DangerNoodle]

Having someone to maintain the tile set would also be desirable, as it is one I prefer (I have found that the set @Chezzo made tends to be much less consistent in art style between the player, monsters, and terrain, despite being well-made).

[Regularitee]

To whom it may concern: I found out I need permission to upload files (push access) to upload the expanded "tiles.png". Can I get that, even if only for a single day?

[Regularitee]

Actually, I realized I could just upload files into comments. Can someone with the relevant powers use this to replace the "/gfx/Mshock32Modded/tiles.png"?

[BorkBorkGoesTheCode]

That would revert #18380. Also, are you going to keep the boba fett helmet and fallout mininuke launcher?

Changelog from the other PR:

The mininuke launcher, SVS-24C and Rivtech helmet have new sprites. White pixels were removed from one of the revolver sprites; The PPSH smg sprite was changed, now its magazine is straight; Unsealed drink cans default to can_drink sprite; The PPSH-41 drum magazine uses the generic drum magazine sprite; The PPSH-41 magazine uses the generic extended pistol magazine sprite. Some lumpiness was removed from a smg sprite. I added my username to the credits.

The new SVS-24C sprite was derived from the SVS-24/24C sprites. The Rivtech helmet was derived from one of the shields and the hockey mask. I am the creator of the mininuke launcher sprite.

You should be able to upload the file to your repository, then PR the change.

[DangerNoodle]

Small problem. I would greatly prefer if the 24x24 version is also maintained.

[Regularitee]

@BorkBorkGoesTheCode I hate to ask, but would it be too much to ask you to splice your modifications onto that tileset image I just posted? I figure that you probably know off by heart what was modified so it'd be much faster, at least compared to me (whom isn't familiar with the changes) to compare each and every sprite between the two versions.

[kevingranade]

The work flow is you fork the repository, make changes in a branch, then
make a pull request based on that branch. Help.github.com is a great
resource for detailed instructions.

[Regularitee]

@Kevingranade Yeah, sorry, I'm a bit new when it comes to github. Lots of experience with debugging, but never really had to use it. Thanks for the info though.

@DangerNoodle It's far easier to maintain one tileset than two (particularly if the second one requires re-sizing or re-drawing assets). From what I've seen of the tile_config.json, the MShock24 tileset is significantly smaller, so has been neglected for a while, and would require a massive amount of work to update. I'd recommend just using the MShock32 and using the zoom out feature in-game, which for most intents and purposes produces a result near identical to using MShock24.

But back on topic, I'd like to push my changes through until I can either get BorkBork's help or play spot-the-difference with the few thousand icons in the tileset to find all his modifications, since it doesn't seem prudent to hold up a fairly large compatibility patch (I think it doubled the size of the tileset_config.json) and 50+ new sprites for the sake of preserving three sprites plus minor tweaks.

I do fully intend to merge the two and re-add borkbork's stuff, once I can figure out where and what all the changes were.

Link to pull request here: https://github.com/CleverRaven/Cataclysm-DDA/pull/19978

[kevingranade]

NP with being new, we all were at some point.

[DangerNoodle]

I still would prefer the 24 version to be updated as well. The view zoom option does not actually suffice. At default zoom in the 32 version you do not get much of a view beyond your immediate area, but zooming out even one step loses a lot of detail. The default zoom level with the 24x24 version is at the ideal ratio of detail to vision range in my opinion, at least when the window is set to approximate 800x600 resolution.

And at present, I cannot actually increase display height beyond around 45 or so without the window intruding into the start bar. This increases resolution to mimic 960x720, but still has minimal effect on visibility gained with this version of the tileset.