Cartodb: Table dependencies map cards broken on Editor

[gfiorav]

Steps to Reproduce

1. Be on editor
2. Create a map from a private dataset
3. Go to dashboard and attempt to delete the dataset

Current Result

The map card for the created map is broken

Expected result

The map card for the created map shows up

[gfiorav]

(Assigned @javitonino as per Jorge Sanz suggestion)

[gfiorav]

cc/ @ramiroaznar

[ramiroaznar]

Hey @gfiorav when you said _the map card is broken_ you mean the thumbnail is not showing anything right?

[ramiroaznar]

It looks like it is happening on all cards from the maps dashboard:

Error in the console: Failed to load resource: the server responded with a status of 404 (Not Found)

{
  errors: [
    "Template 'tpl_5e6153ae_e028_47db_9429_b5edd5f113dd' of user 'solutions-editor' not found"
  ],
  errors_with_context: [
    {
      type: "unknown",
      message: "Template 'tpl_5e6153ae_e028_47db_9429_b5edd5f113dd' of user 'solutions-editor' not 
      found"
    }
  ]
}

[ramiroaznar]

Please take this one first. @enekid

[javitonino]

Oki, so this is a tricky one. Basically, the auth tokens are not being sent in that request, so it fails. Fixing it is a bit convoluted:

• Add auth_tokens to the table presenter (backend) and check security implications.
• Read auth_tokens in frontend and somehow pass them to the URL generator (not trivial, as the parameters are written to DOM instead of using normal function calls).

As a note, I think this bug has been part of carto since the new dashboard (5 years or so).

[gfiorav]

Just to leave the note here, we recently fixed a similar issue (mapcards for org private maps in dashboard).

Links:

https://github.com/CartoDB/cartodb/pull/13119
https://github.com/CartoDB/cartodb.js/pull/1928

[gfiorav]

Bloomberg guys found a workaround, in case it's helpful: https://github.com/cartodb-org/cartodb/pull/272/files

[ramiroaznar]

^^ @javitonino @elenatorro

[javitonino]

Yeah, that's the fix I went for at first, but I went further and refactor it, extracting all that code to a presenter. I don't want to keep maintaining those serialize methods :) Thanks!

[elenatorro]

We have already been talking about this. These changes must also be applied to the static pages we developed for the FE/BE split.

[elenatorro]

I have just checked it and @javitonino's changes are already applied to the frontend files and they work also in the static dashboard, so, it is done 🎉

We only need to fix the tests.

[ramiroaznar]

@elenatorro let me know where can I give you the acceptance! :-)