Cartodb: Analysis results not appearing

[csobier]

@urbanphes, ever since the Geocode workflow change, the Analysis results screen is not appearing after running the the Geocode analysis? I'm noticing this for all Geocode TYPES selected.

FYI: The Analysis results _still appear_ correctly after other analysis (not Geocode) are run. However, there is some weirdness where I won't see the analysis results if I re-run an analysis?

Can you define the expected Analysis Results behavior? This impacts several use cases in Learn.

[matallo]

ahoy @csobier ! from now on @alonsogarciapablo will take care of this discussions, so as much background info on the topic you could provide it will be highly appreciated 🙏

[alonsogarciapablo]

I guess we're referring to this overlay with info about the result of the analysis:

I'm missing some context here but I talked to @matallo and he explained to me that right now that overlay is only displayed the first time each type of analysis is completed.

[csobier]

@alonsogarciapablo, OK, thanks. I understand that analysis results only appear once per map now but this issue is specific to the analysis results not appearing AT ALL when running a GEOCODE analysis (for all geocode types).

I've tried for several different maps using all the geocode types, it never appears. Can you confirm?
(I trying to see the results at least once for ensuring the terminology changes were applied, and for vetting legacy use cases when using the STYLE THIS ANALYSIS feature of the results)

[alonsogarciapablo]

From what I can see, it looks like we only display the results of each analysis the first time the user runs the analysis (for every map). This means that if you already ran a GEOCODE analysis with that user, you won't see the analysis results again.

This is stored in the browser's Local Storage so you might see the results in other computers (and perhaps browser sessions?):

[csobier]

Oh, so only once, ever. Hmmm, ok. I will work with that behavior then. Thanks for clarifying.

[alonsogarciapablo]

This is how it works but I wasn't part of this project so I'm not sure if this is the expected behaviour.
@piensaenpixel can you clarify if this is how this should work (I'm not sure who designed this)? Thanks!

[piensaenpixel]

Uhmm as far as i know the message should appear every time that it finishes

[alonsogarciapablo]

@matallo it this something that Bravo implemented? could you please confirm if this is a feature or a bug 🙏 ? Thanks!

[rubenmoya]

Sorry to jump in!

I'm pretty sure this is related to https://github.com/CartoDB/cartodb/issues/13003, this is the PR related to that issue: https://github.com/CartoDB/cartodb/pull/13039

[matallo]

It appears, just the first time though, as per the changes in the issue @rubenmoya shared

so, if we want it ALWAYS to appear a new issue would have to be created (and prioritized via Response Team, or squad)

[piensaenpixel]

But ari's ticket is related to the on-boarding not to the analysis feedback they are different things.

[alonsogarciapablo]

I think we should revert this change then (#13039). The analysis results screen is important because it includes info about new columns, etc.

@ramiroaznar could prioritise this in the RT 🙏 ?

I'll open another issue to re-implement this (only for the onboarding modal) and add it to the Bravo kanban.

[matallo]

@piensaenpixel Well, they aren't different things actually, they share the same component, thus they behave the same

thanks @alonsogarciapablo !

[ramiroaznar]

Roger that!

[alonsogarciapablo]

Here's the new issue to re-implement this: https://github.com/CartoDB/cartodb/issues/13415. Vamos!

[piensaenpixel]

but i don't think we shouldn't revert it, why don't open an issue for fixing it?

[alonsogarciapablo]

We should revert it first (this should be easy so RT team can take care of it) so that it doesn't impact users and then Bravo can re-implement it properly (this might take a bit more time).

[piensaenpixel]

We are going to work two times, but disagree and commit :)

[ramiroaznar]

This is already fixed.