Cartodb: Add hubspot form newsletter id to /me endpoint request

[elenatorro]

In public maps, we have an input to subscribe to the newsletter. This input is generated by hubspot, but it needs a token to render it.

This is what we currently have at /api/v3/me:

• Form id in app_config.yml: https://github.com/CartoDB/cartodb/blob/master/config/app_config.yml.sample#L89
• Public map footer:
  https://github.com/CartoDB/cartodb/blob/master/app/views/admin/shared/_public_footer.html.erb#L13
• Hubspot form helper
  https://github.com/CartoDB/cartodb/blob/master/app/helpers/application_helper.rb#L113

I was thinking the endpoint should return this value in 'hubspot_ids' stringified json, what do you think?

[juanignaciosl]

I'm not 100% sure, but I'd keep at /me the current configuration structure:

      form_ids:
        newsletter: ''
      event_ids:
        import_failed: ''
       ...

hubspot_ids come from event_ids. I have mixed feelings. We could add a new form_newsletter event at hubspot_ids, or a new attribute hubspot_forms_ids at the same level than hubspot_ids (which should've been hubspot_events_ids). For structure consistency, I'd do the latter, but I'm not 100% sure.

[elenatorro]

I agree with you 👍 what do you think @matallo @javitonino?

[javitonino]

Adding hubspot_form_ids sounds good to me. We can probably add it directly to the frontend config helper (which is used in /me).

[juanignaciosl]

Ey, it's not "adding hubspot_event_ids but hubspot_forms_ids. Current hubspot_ids attribute comes from event_ids. So, the less harm that we can do is adding hubspot_forms_ids from form_ids.

[javitonino]

My head is not what it used to be 🤦‍♂️ Yeah, I meant form_ids (updated my previous comment)

[amartinj]

I've seen that we are json-encoding some config values, but since it's fugly I'll not do it this time :)

[elenatorro]

You mean the hubspot_ids?

[amartinj]

For example, yes. There are some configs that are rendered as a json string, which I strongly dislike

[elenatorro]

Me too. It's good to take this into account because we'll need to change some things in the public views if this changes. Thanks!

[amartinj]

I won't change anything, but simply add this value as a json, not as a string ;). Just commenting because I'm _breaking coherence_. But since we all agree... 😄