Cartodb: Axis labels changes in Time-Series

Created on 28 Aug 2017  路  8Comments  路  Source: CartoDB/cartodb

Context

After several acceptance tests, a few things have to be changed regarding the axis labels. These issues were attached to the out-of-bounds ticket because it was convenient to tackle them in that issue. Since that issue is now blocked, I move those minor issues to this ticket to be addressed on their own.

https://github.com/CartoDB/cartodb/issues/12480

Subissues

Copypasting from those comments.

1

  • [x] To prevent that overlapping its better to align the label not to the dragger but to the bin itself. I attach some mocks:

image

image

2

  • [x] Which drives us to a new bug, the cropped label on the time series limits:

image

3

  • [x] I found this bug. We shouldn't be able to place the handle in the middle of the bucket.

bucket

4

  • [x] Lastly, when selecting only one bucket, we shouldn't display the value of that single bucket twice. There should only be one, above and in the middle of the bucket:

screen shot 2017-08-10 at 13 02 03

Frontend bug

All 8 comments

I have some concerns with this issues. Calling @CartoDB/design to get their point of view.

Regarding 1. It says to align the label to the bin instead of the handle.
This can make sense when dealing with dates but it doesn't when dealing with numeric columns: this bin is Jan 2017 against this bin goes from 130 to 256.
To me, it feels very weird to have different behaviours depending on the column type, something that the user may not be aware of.

Number 4 is related. It says to align only one label if there's only one selected bin in a date column. That will move the labels from handles to bin and will make disappear one of them.

Your thoughts?

Blocked until Design approves the implementation.

@CartoDB/design for acceptance

We already did the acceptance last week, on Friday afternoon. Everything looked good.

Regarding your concerns, @ivanmalagon. IMO I think we should move forward and test it.

Design Seal of Approval. Let's move to Code Review!

seal-of-approval

It works as expected :star: Let's move to production!

:rocket:

Closed by #12766

Was this page helpful?
0 / 5 - 0 ratings