Cartodb: Loading button

Created on 16 May 2017  Â·  10Comments  Â·  Source: CartoDB/cartodb

We need to implement the new loader button

All the code is merged in CartoAssets
https://github.com/CartoDB/CartoAssets/pull/161

If you have any questions ping me :)

Frontend

Most helpful comment

yeah that's right @rubenmoya

All 10 comments

Could you enumerate the places where we should start using it?

sure they are here https://github.com/CartoDB/design/issues/658
but this is the list

  • [ ] Run analysis.
  • [ ] Update the map.
  • [ ] Export as an image.
  • [ ] Apply CSS.
  • [ ] Apply SQL.
  • [ ] Publish

Hey @nobuti, I feel we will need a small explanation about how to update cartoassets package and npm-shrinkwrap thing.

Since we're showing the loading icon, we won't show the "loading", "publishing", "exporting" texts anymore, right?

@piensaenpixel @urbanphes ^^^ ?

yeah that's right @rubenmoya

@piensaenpixel For the run analysis case, should it show the loading indicator as long as the analysis has not finished?

Deployed.

NICE!

On Tue, May 23, 2017 at 15:30, Buti notifications@github.com wrote:
Closed #12132 [https://github.com/CartoDB/cartodb/issues/12132] .

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub [https://github.com/CartoDB/cartodb/issues/12132#event-1093662015] , or mute the thread [https://github.com/notifications/unsubscribe-auth/AAIEMv8a8KjU7GFIEDf0lLIuPYFG6oBwks5r8t-HgaJpZM4NcKxg] .

\o/

Was this page helpful?
0 / 5 - 0 ratings

Related issues

arianaescobar picture arianaescobar  Â·  5Comments

piensaenpixel picture piensaenpixel  Â·  4Comments

xavijam picture xavijam  Â·  5Comments

nygeog picture nygeog  Â·  5Comments

javitonino picture javitonino  Â·  5Comments