Carthage: .version file is not created for Kingfisher

[r-plus]

• carthage install method: [ ] .pkg, [x] homebrew, [ ] source
• which carthage: /usr/local/bin/carthage
• carthage version: 0.33.0
• xcodebuild -version: Xcode 11.0 Build version 11A420a
• Are you using --no-build? no
• Are you using --no-use-binaries? no
• Are you using --use-submodules? no
• Are you using --cache-builds? no
• Are you using --new-resolver? no

Cartfile

github "onevcat/Kingfisher"

Carthage Output

$ carthage bootstrap --platform iOS
*** No Cartfile.resolved found, updating dependencies
*** Fetching Kingfisher
*** Checking out Kingfisher at "5.8.1"
*** xcodebuild output can be found in /var/folders/2q/h0tfw5xj28qgdcs2rqkm62nm0000gp/T/carthage-xcodebuild.I45kJ1.log
*** Downloading Kingfisher.framework binary at "5.8.1 - Borderless"
*** Building scheme "Kingfisher" in Kingfisher.xcworkspace
*** Building scheme "KingfisherSwiftUI" in Kingfisher.xcworkspace

Actual outcome
Carthage did not create .Kingfisher.version file to Carthage/Build/.

Expected outcome
Carthage should create .Kingfisher.version file to Carthage/Build/.

$ ls -la Carthage/Build
total 0
drwxr-xr-x  3 hyde  wheel   96  9 28 20:39 ./
drwxr-xr-x  4 hyde  wheel  128  9 28 20:39 ../
drwxr-xr-x  9 hyde  wheel  288  9 28 20:40 iOS/

AFAIK this issue is happen only for Kingfisher. Is this Kingfisher issue?

[tmspzz]

You’re missing —cache-builds I believe

[r-plus]

Did you mean should add --cache-builds option? But not created .version file even if add that option.

[kenji21]

Hmm, just checked our last CI builds, and .KingFisher.version is not created :/

08:05:24 kenji@macboo:~/Desktop/cart-issue-2882
carthage bootstrap --platform iOS --cache-builds
*** No Cartfile.resolved found, updating dependencies
*** Fetching Kingfisher
*** Fetching Archimedes
*** Checking out Archimedes at "1.1.5"
*** Checking out Kingfisher at "5.8.1"
*** No cache found for Archimedes, building with all downstream dependencies
*** No cache found for Kingfisher, building with all downstream dependencies
*** xcodebuild output can be found in /var/folders/7v/dfg0p2vj1z58n65d99l2n1lh0000gp/T/carthage-xcodebuild.oviTjq.log
*** Downloading Kingfisher.framework binary at "5.8.1 - Borderless"
*** Building scheme "Archimedes iOS" in Archimedes.xcworkspace
*** Building scheme "Kingfisher" in Kingfisher.xcworkspace
*** Building scheme "KingfisherSwiftUI" in Kingfisher.xcworkspace

08:07:55 kenji@macboo:~/Desktop/cart-issue-2882
ls -la Carthage/Build/
total 8
drwxrwxr-x   4 kenji  staff  128 Sep 30 08:06 .
drwxrwxr-x   4 kenji  staff  128 Sep 30 08:05 ..
-rw-rw-r--   1 kenji  staff  167 Sep 30 08:06 .Archimedes.version
drwxrwxr-x  13 kenji  staff  416 Sep 30 08:07 iOS

08:13:32 kenji@macboo:~/Desktop/cart-issue-2882
cat Cartfile
github "github/Archimedes" ~> 1.0
github "onevcat/Kingfisher" ~> 5.6

08:13:37 kenji@macboo:~/Desktop/cart-issue-2882
cat Cartfile.resolved
github "github/Archimedes" "1.1.5"
github "onevcat/Kingfisher" "5.8.1"

[kenji21]

Using my #2400 patched carthage makes the .KingFisher.version be created:

kenji@macboo:~/Desktop/cart-issue-2882
rm -rf Carthage/

09:00:06 kenji@macboo:~/Desktop/cart-issue-2882
~/github/Carthage/.build/debug/carthage bootstrap --platform iOS --cache-builds
*** Checking out Archimedes at "1.1.5"
*** Checking out Kingfisher at "5.8.1"
*** No cache found for Archimedes, building with all downstream dependencies
*** No cache found for Kingfisher, building with all downstream dependencies
*** xcodebuild output can be found in /var/folders/7v/dfg0p2vj1z58n65d99l2n1lh0000gp/T/carthage-xcodebuild.wxkgK0.log
*** Downloading Kingfisher.framework binary at "5.8.1 - Borderless"
*** Building scheme "Archimedes iOS" in Archimedes.xcworkspace
*** Building scheme "Kingfisher" in Kingfisher.xcworkspace
*** Building scheme "KingfisherSwiftUI" in Kingfisher.xcworkspace

09:02:17 kenji@macboo:~/Desktop/cart-issue-2882
ls -la Carthage/Build/
total 16
drwxrwxr-x   5 kenji  staff  160 Sep 30 09:02 .
drwxrwxr-x   4 kenji  staff  128 Sep 30 09:00 ..
-rw-rw-r--   1 kenji  staff  167 Sep 30 09:00 .Archimedes.version
-rw-rw-r--   1 kenji  staff  464 Sep 30 09:02 .Kingfisher.version

Of course using Xcode11 (due to SwiftUI KingFisher's framework)

[onevcat]

As the author of Kingfisher, I have encountered the same issue here 😂

Not sure what can cause it yet, but if there is anything I can do, please let me know.

[onevcat]

I digged into this issue a bit and it seems that if I build Carthage from the master branch, the .version files are generated without problem. So I guess this problem is already fixed in some recent commits.

But it indeed happens in version 0.33.0.

A new release of Carthage would fix this.

[onevcat]

Ref: It seems to be related to https://github.com/Carthage/Carthage/pull/2865

[r-plus]

Carthage 0.34.0 is out. I tried again for Kingfisher version 5.8.1. But still seeing issue.

Cartfile

github "onevcat/Kingfisher" "5.8.1"

Carthage Output

$ carthage bootstrap --platform iOS
*** No Cartfile.resolved found, updating dependencies
*** Checking out Kingfisher at "5.8.1"
*** xcodebuild output can be found in /var/folders/2q/h0tfw5xj28qgdcs2rqkm62nm0000gp/T/carthage-xcodebuild.nht9JG.log
*** Downloading Kingfisher.framework binary at "5.8.1 - Borderless"
*** Building scheme "KingfisherSwiftUI" in Kingfisher.xcworkspace
*** Building scheme "Kingfisher" in Kingfisher.xcworkspace

(install from homebrew)

$ carthage version
0.34.0

$ ls -la Carthage/Build
total 0
drwxr-xr-x  3 hyde  wheel   96 10 22 16:36 ./
drwxr-xr-x  4 hyde  wheel  128 10 22 16:36 ../
drwxr-xr-x  9 hyde  wheel  288 10 22 16:38 iOS/

[r-plus]

yes, https://github.com/Carthage/Carthage/commit/a81ae12d252c3e746a58e674d32e1328043a5815 commit on master is not contains in 0.34.0

[onevcat]

@r-plus I suggest you can try Kingfisher 5.8.3 here https://github.com/onevcat/Kingfisher/releases/tag/5.8.3, in which we had a workaround for this cache issue on our side.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.