Cargo-edit: Release 0.5.0?

[DCjanus]

Because of this, we hope there will be a released version of cargo-edit with #369.

If there is a plan to release such version, I think it should be 0.5.0, that woule be really great.

[tarcieri]

Yes, this would be great. It's pretty much the last blocker on releasing a new version of cargo audit with a cargo audit fix command powered by cargo-edit

[ordian]

I'll try to look into that today or tomorrow.

[DCjanus]

I hope this wouldn't looks a bit harsh, but, any process? 😄 @ordian

[ordian]

@DCjanus I want to merge #374 and #368 first, but it seems that after switching from appveyor to github workflow CI some tests are failing on windows https://github.com/killercup/cargo-edit/runs/375535231. This is probably related to how toml_edit handles newlines, but I need to understand what is the problem first. Would appreciate any help with that :)

[tarcieri]

@ordian I took a quick look at https://github.com/killercup/cargo-edit/runs/375535231 and my first guess is toml_edit is inserting \r\n as the newline of lines it edits, but retaining the Unix \n line-endings on lines it doesn't.

Any idea what it was doing before?

The tests seem to be expecting Unix-style newlines across-the-board.

[ordian]

@tarcieri I haven't updated toml_edit in a while, but it should've folded crlf in to unix-style newline
https://github.com/ordian/toml_edit/blob/520bfe2c81af48664cfe5de16f5357d931aa0832/src/parser/trivia.rs#L41-L47

What is strange is that the tests used to pass on appveyor. We also have a bunch of tests in toml_edit that passed on appveyor and now on windows in github workflow .

[tarcieri]

Looks like this is an MSVC build, which I expect is what you were also doing on Appveyor?

Any discrepancies in MSVC versions or other crate versions? Can you give me a link to a successful Appveyor build?

[ordian]

https://ci.appveyor.com/project/killercup/cargo-edit/history

Also MSVC, yes, not sure which version though.

[ordian]

It seems that github workflow uses Windows Server 2019
And our appveyor build https://github.com/killercup/cargo-edit/blob/82c091924cb9f5f2f94ba50d6884591d8e1736ba/appveyor.yml#L7

[tarcieri]

Other than that I don't see any noteworthy differences. They're both using:

stable-x86_64-pc-windows-msvc - rustc 1.40.0 (73528e339 2019-12-16)

and toml-edit v0.1.5

[ordian]

Alright, I'll merge the PRs manually and release 0.5 soon. The CI failure could be investigated later.
Sorry it took so long.

[ordian]

Published 0.5.0 to crates.io.

[tarcieri]

@ordian thank you!

[DCjanus]

Thank you!

[tarcieri]

@ordian thanks for all your help on this!

cargo-audit v0.11 is now out with a cargo audit fix feature powered by cargo-edit, which I noted in a blog post here:

https://blog.rust-lang.org/inside-rust/2020/01/23/Introducing-cargo-audit-fix-and-more.html