Cardview: Weird lines appearing

[LeoJHarris]

Hi there, noticing an issue have attached gif:

Part of code is this::

PanCardView.CarouselView cardsView = new PanCardView.CarouselView() { ItemTemplate = new DataTemplate(() => new ImageCardItemView()), ItemsSource = list, SelectedIndex = currentPhotoIndex, SlideShowDuration = 3500 };

`BackgroundColor = Settings.XeniaBlackThemeColorAlpha;

        _image = new CachedImage
        {
            Aspect = Aspect.AspectFill,
        };

        frame = new Frame()
        {
            Padding = 0,
            CornerRadius = 10,
            HasShadow = false,
            HorizontalOptions = LayoutOptions.Center,
            IsClippedToBounds = true,
            VerticalOptions = LayoutOptions.Center,
            WidthRequest = 300,
            HeightRequest = 300
        };
        _image.SetBinding(CachedImage.SourceProperty, "Source");
        frame.Content = _image;
        Content = frame;`

......

Oddly Im not getting this issue on your sample.. any ideas?

[AndreiMisiukevich]

Hi
Probably, the reason is in Xamarin.Forms
Could you provide fully reproduction?

[Phenek]

Is this a video from the simulator?

[AndreiMisiukevich]

@Phenek it seems to be a real device
https://play.google.com/store/apps/details?id=com.duapps.recorder&hl=en
But I'm not sure

[LeoJHarris]

@AndreiMisiukevich @Phenek Yes using DU Recorder app as at the link @AndreiMisiukevich mentioned

[AndreiMisiukevich]

@LeoJHarris could you create small sample?
What version of XF do you use?

[LeoJHarris]

Xamarin.Forms version I am using is 3.1.0.697729. Small sample to follow soon

[AndreiMisiukevich]

@LeoJHarris also what api level does your device use

[LeoJHarris]

Have tested on two device 5.1.1 and 7.1.1. Seeing the same issue on both.

[LeoJHarris]

@AndreiMisiukevich Will get a sample before the weekend, today hopefully my hands are a bit tied atm

[AndreiMisiukevich]

@LeoJHarris sure
Probably I will try to reproduce it by myself, or somebody else has the same issue and provide the sample

[LeoJHarris]

I have made a sample repo will submit soon

[AndreiMisiukevich]

@LeoJHarris don't forget

[LeoJHarris]

Sample.zip

Here you go :)

[LeoJHarris]

I copied my own project and stripped out basically everything apart from what was import for the sample. I haven't removed any external .libraries though

[AndreiMisiukevich]

@LeoJHarris

It crashes on start(

[AndreiMisiukevich]

Could you please test it on my sample?
https://github.com/AndreiMisiukevich/CardView/blob/master/PanCardViewSample/PanCardViewSample/Views/CarouselSampleXamlView.xaml

I still think that this is xamarin issue (XF 2.5 works fine)

[amrkamal1993]

I Have the same issue only in android
XF 3.1.0.697729

[AndreiMisiukevich]

@amrkamal1993 try please with Forms 2.5
I guess, we should create issue for Xamarin team

[LeoJHarris]

@AndreiMisiukevich That's a bummer let me check that sample project again. I also think the issue exists in Xamarin.Forms version.

[AndreiMisiukevich]

@LeoJHarris also, try please disable this class and try with forms 3.1-3.2 https://github.com/AndreiMisiukevich/CardView/blob/master/PanCardView.Droid/CircleFrameRenderer.cs

Perhaps, we should remove this class, if Xamarin fixed frame issue (transparent background and colored outline)

[LeoJHarris]

@AndreiMisiukevich Okay

[LeoJHarris]

@AndreiMisiukevich

I think we should remove the CircleFrame with just frame then at least the lines disappear, no issues anymore. I didnt try lowering XF package, infact I bumped to using latest.

Try this:

Sample.zip

[LeoJHarris]

@AndreiMisiukevich BTW I'm still not sure about the side arrows, still doesn't feel totally responsive. Ill give it a go again on your sample and see what it is like removing that line you mentioned on a previous issue I commented in.

[AndreiMisiukevich]

@LeoJHarris hi
Thanks, i appreciate any help with investigation.

[AndreiMisiukevich]

@AndreiMisiukevich

I think we should remove the CircleFrame with just frame then at least the lines disappear, no issues anymore. I didnt try lowering XF package, infact I bumped to using latest.

Try this:

Sample.zip

Yes, agreed. We should remove CircleFrame from IndicatorsControl for 3.2 and next releases
But we must preserve it for previous builds

[AndreiMisiukevich]

@LeoJHarris https://github.com/AndreiMisiukevich/CardView/blob/master/PanCardView/Controls/IndicatorsControl.cs#L58

this line
Do you know, how can we check XF version?
For 3.2 and above we should use Frame, for lower CircleFrame, i'm sure
...
it seems doesn't work

var assemblyVersion = typeof(Label).GetTypeInfo().Assembly.GetName().Version;

[thedjnova]

sorry for my absence but im backkkkk....

I think this will be an issue within the circleframe render. Looks most likely to do with when it overrides the original drawing elements, it is momentarily rendering a regular frame, then it is replacing it with the new frame, then on next render it is doing the same.

Ill take a look into the renderer over weekend and see what I can find.

[LeoJHarris]

@AndreiMisiukevich Sorry I had a look and I couldn't find anything on checking the version of XF either

[AndreiMisiukevich]

So, guys
What version of XF broke the Circle frame renderer?
I believe, we can find something new it XF and use reflection for determining current XF version installed on device -)

[Phenek]

Frames have been Fixed with Xamarin.forms 3.0.
So the Circle frame renderer should work with lower version,
and have to be disabled with 3.0 and later versions

[AndreiMisiukevich]

@Phenek great!) So, we can check for existing FlowDirection property in any view =)

[AndreiMisiukevich]

also I think, i should change arrow from label to image
unicode arrow work so bed (align is wrong)

[AndreiMisiukevich]

try 1.6.4-pre