Carbon: Window title area extends over boxy-style controls

[binyamin]

Describe the bug
When using the boxy window controls, the image title text-area extends over the controls. This is hard to read, and doesn't look nice.

To Reproduce
Steps to reproduce the behavior:

1. In settings, change the window controls type to the last option (boxy).
2. Click towards the top of the window in the image.
3. Type, and watch the text run into the window controls.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots

Info (please complete the following information):

• OS [e.g. macOS, Linux, Windows, iOS]: Linux (xubuntu 20.04)
• Browser [e.g. chrome, safari]: chrome 83

[mfix22]

@b3u would widening the container a bit work for you?

You can do this by dragging the right edge of the Carbon container.

[binyamin]

@b3u would widening the container a bit work for you?

I think that's a great temporary fix. By the way, the carbon container never lets go of my cursor. I have a gif of it. I'll open a new issue. See #1034

I was playing around with the styles. Adding a max-width to the input should eliminate the issue completely. If 54px is the set size of the window controls svg, then the input should have a max-width of calc(100% - 54px).

input {
    max-width: calc(100% - 54px);
}

[mfix22]

@b3u feel free to open a PR with this change. If it's simple, and doesn't break existing styles, I'll probably merge it 🙂

[binyamin]

@mfix22 I noticed that the contributing guidelines is doesn't show the complete command for adding a contribution. It says yarn contrib:add <your GitHub username> instead of yarn contrib:add <your GitHub username> <contribution>. Would you like me to open a new issue?

[mfix22]

I added it 👍

No need to open a new issue for a change as small as that one, you can just open a PR for consideration instead.

[faraz16iqbal]

Is this issue still open?

[mfix22]

@faraz16iqbal there have already been 2 PRs submitted for it, but they have not yet merged, so the issue is still open.