Carbon: [button] focus should be 2px border

[laurenmrice]

The focus border of the button needs to be 2px. Right not it is a lot thicker than it should be.

In Code now:

Spec:

[xxxle0]

after change the border to 2px
Is it what you expected ? @laurenmrice

[laurenmrice]

The white/transparent space between the button and the border should be 1px. and the focus border should be 2px. Is there a pr for this?

[xxxle0]

ok let me create a PR for it but let me ask the dev team before create it.
Did we implement any button property in theme for the focus width ? We are using $button-outline-width (1px) in theme for the focus width.

[tw15egan]

@xxxle0 Looks like we can change $button-border-width to 2px and $button-outline-width to 2px in src/globals/scss/_theme-tokens.scss

I'm going to assign this issue to you if you are willing to submit a PR 🙂 Feel free to remove it if you aren't able to work on it.

[xxxle0]

hi @tw15egan, if we change $button-outline-width to 2px -> it will effect to outline tooltip of button. I think we can create a PR that make easier to review.

[xxxle0]

5290 this is my PR follow @tw15egan suggestion

[asudoh]

@laurenmrice @tw15egan Do you think this has been fixed by #5618? I see #5290 has been incorporated to master, but wanted to double-check with you. Thanks!

[laurenmrice]

Yes this has been fixed !