Carbon: [Theme sandbox]: assorted bugs

Created on 19 Jul 2019  ·  8Comments  ·  Source: carbon-design-system/carbon

I've found a few different bug with the internal theme sandbox.

  • [ ] Disabled buttons not updating in preview

    • I doubled checked the tokens in the code itself and they're correct but for some reason the sandbox isn't rendering the update.

      image

  • [ ] Disabled content switcher not updating in preview
    image
  • [ ] “Menus” in sandbox, not changing themes with switcher

    • ~Date picker~ fixed

    • Overflow menu

    • Tooltip

      (still the white theme menu)

  • [ ] Not exporting correct values for output:

    • export const hoverUI

    • export const activeUI

    • export const selectedUI

    • export const hoverSelectedUI

  • [ ] Notification: inline (low contrast) is showing toast notifications instead of inline
bug 🐛

All 8 comments

Discussion ongoing wrt where further changes to theme sandbox should be hosted. CC @shixiedesign

@aagonzales would the work @vpicone has done on the website to add the themes per component be a replacement for the sandbox? Or do we still need the sandbox as a place to have all components in one spot??

@alisonjoseph The nice part about the sandbox is that users can make custom themes and see how the tokens work. Vince's component demo only shows the components as they are in the four set themes. You can also export your custom theme here so I guess it is nice to see all the components together. I think this sandbox would still be a nice tool to have.

I thinks its a handy design system tool, it would be nice to get the type tokens in it as well.

Makes sense, will leave this open and figure out when we can prioritize it

@alisonjoseph if we're going to invest in this tool it would be nice if we can also take a design pass at it and get it up to v10 standards. But I guess that would be a different issue than just fixing these bugs.

Going through old issues today and am going to close this out since I think we aren't working on this any more? Feel free to re-open if I'm mistaken!

@joshblack @alisonjoseph so the theme sandbox is still live. If we dont want to clean it up then I think we should take down the site. https://themes.carbondesignsystem.com/?nav=accordion

It would be nice to build a new fancy theme sandbox sometime in the future. Especially if we switch to building more tooling instead of components.

Was this page helpful?
0 / 5 - 0 ratings