Carbon: AVT 1 &AVT 2 - Default Tooltip has keyboard issue and TooltipDefinition and Icon have DAP violations

[snidersd]

This issue is related to #2458
Retested after the latest fix #2656 and there is still a DAP failure.

The original fix for #2458 was to remove aria-labelledby="_carbon-tooltip-trigger_qonq7h6yqf", but the aria-label="tooltip" was also removed which is causing the new violation. (see screenshot):

Please add aria-label="tooltip" back in to fix.

[emyarod]

hi @snidersd! #2656 only removes the aria-labelledby attribute. after doing a bit of digging it seems this violation is instead caused by https://github.com/carbon-design-system/carbon/commit/6190488395c47db94c42e568604a9c15e4445085 (this commit was originally contained in https://github.com/carbon-design-system/carbon-components-react/pull/2245 but the PR links were broken during the monorepo move).

if I understand correctly, we are getting conflicting information (or have misinterpreted the feedback) about the necessity of aria-label="tooltip" in https://github.com/carbon-design-system/carbon-components-react/issues/2193. can we get additional clarification before proceeding with any changes?

[snidersd]

@dakahn Please add the react label to this issue. Thx!

[snidersd]

@dakahn Please add this issue to the IBM Carbon Copy Milestone. Thx!

[snidersd]

I'm only seeing the DAP issue with the TooltipDefintion and the TooltipIcon. However, the Tooltip, which is actually a Modal does not restrict tab focus to the modal.

[dakahn]

@snidersd Circling back on this. Looks like the DAP errors are cleared 🥂.

As for the AVT2 (keyboard a11y) violation what we're talking about is making our tooltip if it's open? Or only tooltips that have links/buttons in them? I'm not a huge fan of using tooltips in that way anyway (hiding options etc) -- my assumption is that this isn't suggested use, but we're just showing off _what you could do_.

If we changed our example would a focus trap still be necessary?

[elizabethsjudd]

@snidersd @dakahn this is a related PR that i'm working on to resolve AVT 2 and 3 in vanilla #3476

[snidersd]

@dakahn IMO we should keep React and Vanilla in sync. I think we should look at updating React when the related PR Liz has open #3476 is complete.

[elizabethsjudd]

@snidersd @dakahn I've had PRs merged that corrected the DAP violations in Definition and Icon tooltips for Vanilla: https://github.com/carbon-design-system/carbon/pull/3151 and https://github.com/carbon-design-system/carbon/pull/3115

[dakahn]

Cool! I'll wait for @elizabethsjudd's PR to drop and then port changes over 👍

[snidersd]

After retesting this issue, the Default Tooltip still has a DAP violation. See screenshot below:

In addition, the Learn More Link and Create button cannot be activated using only a keyboard.
Note: The DAP issue is only present when the button is not pressed.

[dakahn]

We should open a separate ticket for the inaccessible tooltip elements. My hunch is that we actually don't intend our tooltips to have confirmation buttons etc...

[dakahn]

@snidersd Couldn't we classify this DAP error as a React app false positive? If the tooltip has focus -- it's open. And if it's open, that aria-describedby id is valid. It's only in the situation where we're scanning the DOM using AAT that this is a problem unless there's something I'm missing.

[elizabethsjudd]

@dakahn the DAP violation @snidersd was getting was because the ID started with an underscore.
IDs must start with a letter in order to be valid.