Carbon: Add typedefs to DefinitelyTyped

Created on 2 Feb 2019  路  8Comments  路  Source: carbon-design-system/carbon

We should add the typedefs for elements-related packages as part of our docs push to DefiniteTyped.

elements dev 馃 inactive

Most helpful comment

I'll take a crack at this.

All 8 comments

I'll take a crack at this.

I鈥檒l track the PRs here:

| Package | PR | NPM |
| ------------- | ------------- | ------------- |
| colors | https://github.com/DefinitelyTyped/DefinitelyTyped/pull/32837 | @types/carbon__colors |
| themes | https://github.com/DefinitelyTyped/DefinitelyTyped/pull/32839 | @types/carbon__themes |
| layout | https://github.com/DefinitelyTyped/DefinitelyTyped/pull/32861 | @types/carbon__layout |
| motion | https://github.com/DefinitelyTyped/DefinitelyTyped/pull/32862 | @types/carbon__motion |
| type | https://github.com/DefinitelyTyped/DefinitelyTyped/pull/32865 | @types/carbon__type |
| elements (collection) | | |

All the PRs got merged so they're all available through npm. When making the @carbon/elements TS threw an error since both type and layout export a spacing variable so we'll need to rename one or the other for that package.

TypeScript to the rescue? 馃槣

Yes! 馃檹 And maybe some more tests too 馃槄 lol

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. Thanks for your contributions.

As there's been no activity since this issue was marked as stale, we are auto-closing it.

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

As there's been no activity since this issue was marked as stale, we are auto-closing it.

Was this page helpful?
0 / 5 - 0 ratings