on tabs/etc that use a border to highlight the current location, the border should be a minimum of 3px to meet accessibility standards. this is a a thing i've had to implement in a couple places on the website.
i recommend making a new token for this width, and then doing a pass thru all of our components to make sure any 2px borders are bumped up to this
Makes sense to me, @IBM/carbon-developers any thoughts? Also should this be in carbon-elements?
@asudoh you're right! transferred here to carbon-elements :)
We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. Thanks for your contributions.
un-staling :)
Hey @lovemecomputer , how are you planing to add the token for border? is it possible to make it scalable to include more border tokens? Eg. we need borders applied to buttons now (dark themes only), and these will be ideally tokenized so themeing could remove / customize it.
@shixiedesign sure, we could add any tokens that make sense to be a part of the system! it would probably be best to open a separate Issue for that, especially if you have in mind particular components the tokens apply to. that could potentially fit inside of components, since it's border measurements specifically for buttons.
thoughts on naming/organization of this token:
i asked @aagonzales over slack about filing this under a layout or spacing name. anna said:
I dont think those, the
spacingandlayouttokens are for the empty spaces. You wouldn't use it for a border. Spacing essentially equalsmarginorpadding.
I think you thinking more of something that would be like
sizing. Which we could add but its kind of like the mini unit increments.
good note on a set of sizing tokens.
@shixiedesign sizing token category might be good for the button borders you mentioned as well!
We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.
As there's been no activity since this issue was marked as stale, we are auto-closing it.