Carbon 1.37.0 causing exceptions on all add/sub methods

[robinnydahl]

Hey there,

We've started to experience this exception when we first had a deployment today before this commit, all went okay. Then we made a second deployment a while back after it was merged to master, bumping the version up to 1.37.0. Now we have application wide failures.

For example when we run:

Carbon::parse('2019-01-01)->subDays(1)->isToday()

We get:

BadMethodCallException: Method subDays does not exist.

The same issue goes for all sub/add of Days, Hours, Minutes, Seconds. We've manually downgraded to the 1.36.2 version for now and the issue is then gone.

Carbon version: 1.37.0
PHP version: 7.1.28
Laravel version: 5.5.45

Thanks!

[robinnydahl]

Ping: @matt-allan and @kylekatarnls

[matt-allan]

I don’t think it’s that change, it’s a bad tag. It looks like master was tagged as 1.37 which means it contains all of the 2.0+ breaking changes?

[robinnydahl]

@matt-allan That's correct, indeed.

1.37.0 include all the code from it's parent commit which is 2.17.1. Seems the tags have been mixed here.

Do you have the possibility to revert and fix the tags so this breaking change can be fixed.

[matt-allan]

I can’t create tags, only maintainers can. I think you need @kylekatarnls to do that.

[kylekatarnls]

Tag removed, i Will retag today

[kylekatarnls]

Patch released.

[kylekatarnls]

Run composer update to get 1.37.1.