Carbon: Inline loading design fix

Created on 9 Jan 2019  路  4Comments  路  Source: carbon-design-system/carbon
  • [ ] Inline loading implemented design is not the same as spec.

Current implementation on next.carbon site
image

Spec
image

  • [ ] Design spec is missing finished states (both success and error)
    Current implementation on next.carbon site
    image.png
    Shixie propose:
    image.png
    Some explorations on this state:
    image

  • [ ] Guideline says inline loader replaces button. This feels weird to me based on below implementation. Button is too big / prominent and our inline loader type is only 12px G70.
    motion_inline-loading_v10

dev 馃 visual review 馃攳 bug 馃悰 10
Source
picture shixiedesign

All 4 comments

Refs IBM/carbon-components#1749

asudoh picture asudoh on 8 Feb 2019

CC @dakahn

asudoh picture asudoh on 22 Feb 2019
👍1

Spec & Sketchfile

https://ibm.box.com/s/quzwd4vj94mj6i8wjbxdjuxn1xt6wret
image

shixiedesign picture shixiedesign on 25 Feb 2019

Closing because fixes mentioned in this issue are now consolidated in issue https://github.com/IBM/carbon-components/issues/1906

shixiedesign picture shixiedesign on 25 Feb 2019
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

xrissot-ibm picture xrissot-ibm  路  3Comments
jendowns picture jendowns  路  3Comments
ahoyahoy picture ahoyahoy  路  3Comments
skaparelos1 picture skaparelos1  路  3Comments
laurenmrice picture laurenmrice  路  3Comments