Carbon: [Tabs] Add a secondary style

[stanislavgeorgiev]

Summary

My project requires an alternative styling for the Tabs component which looks like this:

I can make the style updates this or next week and contribute it back if that new design is deemed to be useful to Carbon. Any notes from Design to make the above style compliant with the Carbon are very much welcome.
(https://ibm-studios.slack.com/archives/C0M053VPT/p1540402619000100?thread_ts=1540400543.000100&cid=C0M053VPT)

[alisonjoseph]

@IBM/carbon-designers fyi

[jeanservaas]

@stanislavgeorgiev

This is what's coming down the pipe for Carbon v11. Like I said, these guys are spec'd but are not going to make the Carbon X release. Also note, they're in the new design language style... and we're still hammering out our color tokens for the light theme.

If you want to contribute something back to Carbon, it would make sense to use this structure. @aagonzales suggested you could just use the existing Carbon colors in the meantime...

[stanislavgeorgiev]

Thanks @jeanservaas, that's going to be very helpful!
When would those changes end up in master if I make them?

[jeanservaas]

There's no reason a tab variation couldn't go into the Experimental components right away. The reason we're not doing it is that we have limited resources so we have to focus just on matching what's in Carbon right now for the X release. If your team develops it to spec we could try to include it for X.

[tw15egan]

@stanislavgeorgiev you can take a look at our other components that have experimental versions to see how we are going about it:

https://github.com/IBM/carbon-components/blob/master/src/components/list/_list.scss

[stale[bot]]

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. Thanks for your contributions.

[aagonzales]

This is something we will need. I've already seen teams like Cloud using this in their designs. Not stale.

[shixiedesign]

Hi @stanislavgeorgiev ! Just wanna check in to see if you've got to create the secondary style for Tabs. Keep us posted and lemme know if you need any additional info/spec. Thanks!

[stanislavgeorgiev]

@shixiedesign No, I haven't had a chance to work on it yet. I may get some time in several week to work on this.

[stale[bot]]

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

[laurenmrice]

not stale

[stale[bot]]

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

[stanislavgeorgiev]

Still active

On Aug 9, 2019, at 4:27 PM, stale[bot] [e-mail] wrote:

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[jeanservaas]

Also, like @aagonzales we've seen these designs from Intratstructure and Containers teams -- I know Erica Raymond was taking about contributing it back to Carbon. I'll follow up with her on it too.

[stale[bot]]

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

[stanislavgeorgiev]

Still active

[asudoh]

@jeanservaas @aagonzales Looking at the spec image, which has several IBM color references. Do we have mappings of those to our theme tokens? (My apologies if I'm missing something) Thanks!

[aagonzales]

Nope, we didn't have the tokens on there. Here's the spec with color tokens

[asudoh]

Super 🎉 - Thanks a lot @aagonzales!