Carbon: "Save Image" option is not working in Firefox

[micnic]

As the title says, when click on Save Image button in Firefox nothing happens.

[nozzlegear]

Also does not work in Edge (neither does the Tweet Image button).

[briandennis]

@micnic I pushed a fix, it should be working on Firefox now.

@nozzlegear Is the Save Image button working on Edge now? I can check myself later today, but don't have access to Edge at the moment...

[micnic]

@briandennis, thanks it works fine, you are awesome !

[briandennis]

@micnic glad I could help!

[briandennis]

Going to close this. Will reopen another issue if the problem on Edge persists

[nozzlegear]

@briandennis I've done some investigating with Edge and it looks like the dom-to-image package isn't tested in and doesn't support Edge (or Safari I guess): https://github.com/tsayen/dom-to-image/issues/78. Specifically the .toPng function fails with Edge complaining that the canvas is dirty.

I switched out .toPng() with .toSvg() which got me further, the browser was able to create the data URL. However I was unable to actually navigate to that data URL, download it or even just copy it to my clipboard to navigate there manually. It would just crash Edge instead.

Not sure how much work you want to put into this issue, it's probably just easier to add a note that Carbon doesn't support Edge!

[mfix22]

@nozzlegear thanks so much for investigating. We plan to replace dom-to-image with a cross-browser solution. We really appreciate the work you did.

[nozzlegear]

No problem! Looking forward to a cross browser Carbon.

[mfix22]

@nozzlegear opened #28 so you can track it (: