Caprine: App icon problem in Linux

Created on 24 Mar 2018  路  15Comments  路  Source: sindresorhus/caprine

I have a problem with icon i Ubuntu 17.10. The icon is default application icon (not electron icon) but when Caprine is opened it has separate indicator from the pinned one but this indicator HAS an icon tho it is larger size.
image
The fourth icon from top is pinned Caprine and the last icon is opened Caprine window indicator. The last icon clearly has higher resolution and it looks ugly.
I haven't tried on any other distro tho.

By the way I've been building Caprine myself lately and this has appeared somewhere around commit that updated build directory structure (https://github.com/sindresorhus/caprine/commit/065aa47ed191f2d251a134b8947b7d7131d41d8f).

  • Electron version: 1.7.10
  • OS: Ubuntu 17.10

Most helpful comment

Keeping this open so I remember to revert it when it鈥檚 fixed in electron-builder.

All 15 comments

Same on Mint 18.3 and Docky, it uses the default icon. No unread badges visible either (not sure if this is supported on Docky, but if not it would be a great addition). Screenshot attached.

screenshot from 2018-04-09 08-32-29

Any update on this?

The unofficial Microsoft Teams electron wrapper has no problem with this and the code should be quite similar i suppose: https://github.com/ivelkov/teams-for-linux

Well the solution to the problem is simple. Add icons folder in build that contains icons of different sizes like in ivelkov/teams-for-linux. This would be just a temporary solution until this issue is fixed in electron-builder! Any thoughts about adding this @sindresorhus? I can do a PR for this.

Note: This is a fix for Linux only since this issue appears only on Linux.

I've done the recommended workaround in 2.13.0.

Thanks!

Keeping this open so I remember to revert it when it鈥檚 fixed in electron-builder.

The workaround made sure that the icon was there, but it's not linked to the .desktop file, so if you add it as a favorite, it's a different icon as the running instance.

I think it is missing a StartupWMClass property.

Allright, adding a StartupWMClass=caprine fixes that. Who creates that desktop file? Is it also electron?

electron-builder

It seems this is controlled trough the linux.desktop parameter in the package.json.
See https://github.com/ivelkov/teams-for-linux/blob/b107aa8e9078d3f9c64e8b4b985ceb83816024a6/package.json#L38

I'm not sure how to test this, but I guess this could work: https://github.com/michaelarnauts/caprine/commit/b6d28a7cbf8f2d6a6f5ad78d2eb854d577b729a1

@michaelarnauts This should be fixed in electron-builder. Open an issue over there.

This issue is resloved. Closing the issue.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

bsucker98 picture bsucker98  路  3Comments

dmythro picture dmythro  路  4Comments

ChristianKlee picture ChristianKlee  路  4Comments

sindresorhus picture sindresorhus  路  4Comments

mmatyas picture mmatyas  路  3Comments