Describe the bug
PVS team has analyzed the Calculator's code and here is the review.
https://habr.com/en/company/pvs-studio/blog/443400/
You probably should at least take a look.
Additional context
I'm stating the article here with several bugs revealed by static analizator. Just ignore the issue in case you don't think its important or my report is not properly prepared.
Thanks @0x49D1. We're aware of that article, and we're excited about his interest (and yours) in the project, and think he found some great stuff for us to work on. We are absolutely interested in getting clean and staying clean on static analyzer issues, as well as others. We will be adding some guidance to the repo this week for how the community can help us towards that goal (some contributors like @janisozaur have already been addressing some of them). Closing this specific issue as the blog covers a bunch of different issues, and we'll be creating separate tracking issues for those different cases.
Thanks!
袦袗袥袨袥袝孝袣袠
Thanks @0x49D1. We're aware of that article, and we're excited about his interest (and yours) in the project, and think he found some great stuff for us to work on. We are absolutely interested in getting clean and staying clean on static analyzer issues, as well as others. We will be adding some guidance to the repo this week for how the community can help us towards that goal (some contributors like @janisozaur have already been addressing some of them). Closing this specific issue as the blog covers a bunch of different issues, and we'll be creating separate tracking issues for those different cases.
Thanks!
Great! I just wanted to state that to you, in case you've not seen.. So keep up guys, calculator can become just better from all this "open source" movement.
This is your friendly Microsoft Issue Bot. I've seen this issue come in and have gone to tell a human about it.
Most helpful comment
Thanks @0x49D1. We're aware of that article, and we're excited about his interest (and yours) in the project, and think he found some great stuff for us to work on. We are absolutely interested in getting clean and staying clean on static analyzer issues, as well as others. We will be adding some guidance to the repo this week for how the community can help us towards that goal (some contributors like @janisozaur have already been addressing some of them). Closing this specific issue as the blog covers a bunch of different issues, and we'll be creating separate tracking issues for those different cases.
Thanks!