Caddy: import converting absolute path to relative path

Created on 11 Aug 2016  路  5Comments  路  Source: caddyserver/caddy

for example: in my Caddyfile I have an import /home/avail/.caddy/*.conf, in a conf there, let's say /home/avail/.caddy/avail.pw.conf I have import /etc/caddy/common.conf, and it tries importing /home/avail/.caddy/etc/caddy/common.conf

bug

Most helpful comment

Sorry for taking so long @mholt.
I'll take a look asap.

All 5 comments

@avail Thanks for the report. Could you please pull down the importfix branch and see if that resolves the issue for you? (specifically the new commit, https://github.com/mholt/caddy/commit/2321e6d1bf418bf84d5f969556fde73b77c92b68)

Also I think @pedronasser might be interested in reviewing this as well since the code I modified was introduced in d7698ecf1319b116171bc5deb6a357061574da08, but I am not sure why the chunk I removed was necessary, since it seems to be the cause of this bug (and the tests pass without it).

Ping. @pedronasser - can you take a look? @avail - does that work for you?

Sorry for taking so long @mholt.
I'll take a look asap.

@mholt sorry, I can't really test as I have no Golang experience whatsoever. :( I usually just grab the latest build from the site.

@avail Okay, thanks for letting me know. I'm pretty sure I was able to reproduce your issue, just waiting for Pedro to OK it.

Was this page helpful?
0 / 5 - 0 ratings