Cache: 404 when key contains slash

[alexlamsl]

I think this has the same root cause as #43, except I am using my own custom string with slash (tmp release/benchmark) and receives 404 when trying to save the cache.

https://github.com/alexlamsl/UglifyJS2/runs/287169751

[chancancode]

Seems like the cache key should be URL-encoded!

[joshmgross]

The cache key is already URL-encoded (see cacheHttpClient.ts) but I think there's some middleware on the server-side that's decoding it incorrectly, leading to the 404.

I'll leave this open since https://github.com/actions/cache/issues/43 has already been closed.

[fsimonis]

This issue extends to other symbols such as +.

I am compiling C++ code using the compilers g++ and clang++, which I put in the build matrix and in the cache key name. This results in 404.

[alexlamsl]

Yes, % also doesn't work etc.

Wouldn't be so problematic if we can manipulate strings to replace certain characters, but since we can't it is kind of a showstopper issue 😓

[joshmgross]

Just an update, we're rolling out a fix on the server-side for this sometime today or early next week.

[zarenner]

The fix for the / issue has been deployed:

The fix for other special characters such as + and % is still in progress.

@alexlamsl @fsimonis while it's true that there isn't a replace expression function that would help here, you should be able to use ::set-output with sed or similar to do string replacement as a workaround.
e.g.

    - name: Sanitize key
      id: sanitize-key
      run: echo "::set-output name=key::$(echo $key | sed 's/+/plus/g')"  
    - uses: actions/cache@v1
      with:
        key: ${{ steps.sanitize-key.outputs.key }}
        path: .

Not the most ideal workaround, but unless I'm misunderstanding hopefully that'll work for you in the meantime!

[alexlamsl]

@zarenner thanks for the fix & the tip on string manipulations :+1: