Cabal: You're awesome! We're giving you commit bits.
Hello @thumphries, @sjakobi, @accraze, @headprogrammingczar, @randen, @aisamanra, @kolmodin, @mightybyte, @gbaz, @garetxe, @komadori, @mgsloan, @lukexi, @mpkh, @pra85, @tvestelind, @corngood, @gelisam,
You're receiving this message because you recently contributed to Cabal. We value your contribution to Cabal, and so in the style of The Pull Request Hack, we are giving you commit bits. There are a few common sense rules about pushing to master (e.g., https://github.com/haskell/cabal#conventions — especially, keep the CI green and PR big changes before pushing), but mostly, be bold!
This is a new experiment for all of us and if there are things that are confusing and unclear please ask, we will try to clarify as much as possible.
P.S. If you know anyone I missed, please let me know.
ezyang
All 100 comments
Also added @Blaisorblade since he's the one who originally proposed this idea and has contributed some patches in the past.
23Skidoo
on 17 Jul 2016
Wohoo! First of all, thanks! :)
This also gives access to edit in the issue tracker. I've missed this in the past when I've seen {mis,un}labeled issues. Great!
So you do most development against master but bigger features in feature branches?
New releases are always made from master?
kolmodin
on 20 Jul 2016
@kolmodin
So you do most development against
masterbut bigger features in feature branches?
Basically yes, big features are expected to go through code review before merging.
New releases are always made from
master?
From release branches. For example, all 1.24 releases are made from the 1.24 branch.
23Skidoo
on 20 Jul 2016
From release branches. For example, all 1.24 releases are made from the 1.24 branch.
Ah, ok. And the release manager is responsible for merging fixes and updates from master to the release branch for minor releases?
kolmodin
on 20 Jul 2016
Yeah, at the moment only the release manager is supposed to touch the stable branches. But if that is not working for people we can reconsider.
FWIW, I know some people work on big features by running feature branches but my personal style is maintaining patchsets which I continually rebase on HEAD, the idea being that self-contained patches are easier to CR. I'm not sure we should enforce this on everyone though.
ezyang
on 20 Jul 2016
CR?
Sent from my iPhone
On 20 Jul 2016, at 19:56, Edward Z. Yang [email protected] wrote:
Yeah, at the moment only the release manager is supposed to touch the stable branches. But if that is not working for people we can reconsider.
FWIW, I know some people work on big features by running feature branches but my personal style is maintaining patchsets which I continually rebase on HEAD, the idea being that self-contained patches are easier to CR. I'm not sure we should enforce this on everyone though.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
phadej
on 20 Jul 2016
Code review!
ezyang
on 20 Jul 2016
@acfoltzer added!
ezyang
on 21 Jul 2016
Wow, this is a very active project! My inbox is already overflowing with
GitHub notifications from the project, mostly about features I've never
heard of. I guess I'll keep lurking until I get a better idea of what's
going on, or until I see a bug go by which I think I'd be able to fix.
Thanks for adding me!
On Jul 21, 2016 12:38 AM, "Edward Z. Yang" [email protected] wrote:
@acfoltzer https://github.com/acfoltzer added!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/haskell/cabal/issues/3567#issuecomment-234154927, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAC_aCE0f7-9ZsqGFiy2w-njTYb-P-dJks5qXvexgaJpZM4JOGld
.
gelisam
on 21 Jul 2016
@gelisam Sorry about the spam! If you (or anyone else) don't want to get notifications for ALL tickets, I think the "unwatch" button should work. But also feel free to lurk / ask questions!
ezyang
on 21 Jul 2016
Also added @snoyberg since he has contributed patches and bug reports in the past.
23Skidoo
on 22 Jul 2016
Thanks :)
snoyberg
on 22 Jul 2016
Added @NovaDenizen for https://github.com/haskell/cabal/pull/3657
ezyang
on 1 Aug 2016
Added @0xmohit for https://github.com/haskell/cabal/pull/3660
ezyang
on 2 Aug 2016
Added @mmakowski for his past contributions.
23Skidoo
on 3 Aug 2016
Added @fmaste for https://github.com/haskell/cabal/pull/3670
ezyang
on 5 Aug 2016
Thanks!!
fmaste
on 7 Aug 2016
Just found meta:easy for those looking for for ideas to get started:
https://github.com/haskell/cabal/issues?q=is%3Aopen+is%3Aissue+label%3A%22meta%3A+easy%22
Blaisorblade
on 15 Aug 2016
Added @RyanGlScott for #3697 and #3704.
23Skidoo
on 18 Aug 2016
Added @alanz for https://github.com/haskell/cabal/pull/3734
ezyang
on 30 Aug 2016
Added @jaccokrijnen for #3757
ezyang
on 1 Sep 2016
Added @erantapaa for #3765
ezyang
on 3 Sep 2016
Added @arybczak for #3769
ezyang
on 3 Sep 2016
Added @omefire so he can assign himself #3795
ezyang
on 8 Sep 2016
Added @sopvop for #3830.
23Skidoo
on 12 Sep 2016
Added @brendanhay for #3844.
ezyang
on 15 Sep 2016
Added @arianvp for #3900
ezyang
on 26 Sep 2016
Added @quchen for #3949 and #3952.
23Skidoo
on 8 Oct 2016
Added @christiaanb for his past contributions.
23Skidoo
on 8 Oct 2016
Added @holzensp for #3959.
23Skidoo
on 8 Oct 2016
Added @fmthoma for #3960 and #3961
ezyang
on 8 Oct 2016
Added @niteria for #3974.
23Skidoo
on 12 Oct 2016
Added @christiantakle, who is going to be working on the website together with @arianvp (#4013).
23Skidoo
on 24 Oct 2016
Added @dagit for https://github.com/haskell/cabal/pull/4037
ezyang
on 26 Oct 2016
Added @sheyll for https://github.com/haskell/cabal/issues/1493
ezyang
on 28 Oct 2016
Added @abooij who is going to work on #4049.
ezyang
on 29 Oct 2016
Added @Ericson2314 for #4055
ezyang
on 29 Oct 2016
Added @juhp for #4099 and his past contributions.
23Skidoo
on 11 Nov 2016
Added @chpatrick for #4105.
ezyang
on 13 Nov 2016
Added @DanielG for #4114.
23Skidoo
on 15 Nov 2016
Added @ilovezfs for #4117.
23Skidoo
on 16 Nov 2016
Added @robjhen for #4211.
23Skidoo
on 6 Jan 2017
Added @dmwit for #4264
ezyang
on 26 Jan 2017
Added @alexbiehl for https://github.com/haskell/cabal/pull/4289
ezyang
on 2 Feb 2017
Added @sergv for https://github.com/haskell/cabal/pull/4302
ezyang
on 7 Feb 2017
Added @slpopejoy for #4320
ezyang
on 13 Feb 2017
Added @bugthunk for #4426.
23Skidoo
on 28 Mar 2017
Added @pranitbauva1997 for working on #3943.
ezyang
on 27 Apr 2017
Added @fgaz for #4491.
23Skidoo
on 3 May 2017
Added @bitrauser for #4490.
ezyang
on 7 May 2017
Added @colinwahl for https://github.com/haskell/cabal/pull/4504
ezyang
on 7 May 2017
Added @p-alik for #4584.
23Skidoo
on 4 Jul 2017
Added @ivan-m for #4591.
23Skidoo
on 7 Jul 2017
Added @amir for #4605.
23Skidoo
on 17 Jul 2017
Added @suzumiyasmith for #4612.
23Skidoo
on 22 Jul 2017
Added @alang for https://github.com/haskell/cabal/pull/4638
ezyang
on 29 Jul 2017
Added @themoritz for #4664
ezyang
on 5 Aug 2017
Added @tfausak for #4692 and #4693.
23Skidoo
on 15 Aug 2017
Added @cocreature for #4176.
23Skidoo
on 22 Aug 2017
Added @vedksah for #4717.
23Skidoo
on 23 Aug 2017
Added @peti for #4725.
23Skidoo
on 28 Aug 2017
Added @bucklereed for #4732.
23Skidoo
on 19 Sep 2017
Added @vaibhavsagar for #4804.
23Skidoo
on 1 Oct 2017
Added @recursion-ninja for #4810.
23Skidoo
on 3 Oct 2017
Added @Mistuke for #4835.
23Skidoo
on 21 Oct 2017
Added @cj285 for #4916.
23Skidoo
on 29 Nov 2017
Added @gwils for #4945.
23Skidoo
on 11 Dec 2017
Added @NathanConroy for #4947.
23Skidoo
on 11 Dec 2017
Added @psiska for #4950.
23Skidoo
on 12 Dec 2017
Added @dalaing for #4948, #4946, and #4940.
23Skidoo
on 12 Dec 2017
Added @kmicklas for #5066.
23Skidoo
on 23 Jan 2018
Added @harpocrates for #5140 and #5141.
23Skidoo
on 13 Feb 2018
Added @takenobu-hs for #5130.
23Skidoo
on 13 Feb 2018
Added @takano-akio for #5101.
23Skidoo
on 13 Feb 2018
Added @TravisWhitaker for #5118.
23Skidoo
on 13 Feb 2018
Added @merijn for #5237.
23Skidoo
on 28 Mar 2018
Added @quasicomputational for #5284.
23Skidoo
on 26 Apr 2018
Added @felixonmars for #5364.
23Skidoo
on 8 Jun 2018
Added @qnikst for #5302.
23Skidoo
on 8 Jun 2018
Added @roman-kashitsyn for #5368.
23Skidoo
on 9 Jun 2018
Added @trommler for #5384.
23Skidoo
on 20 Jun 2018
Added @danidiaz for #5385.
23Skidoo
on 20 Jun 2018
Added @ChShersh for #5456 and @vrom911 for #5478.
23Skidoo
on 31 Jul 2018
Added @domenkozar for #5561.
23Skidoo
on 27 Sep 2018
Added @nkly for #5598.
23Skidoo
on 7 Nov 2018
Added @m-renaud for #5657.
23Skidoo
on 7 Nov 2018
Added @watashi for #5670.
23Skidoo
on 7 Nov 2018
Added @DavidEichmann for #5673.
23Skidoo
on 8 Nov 2018
Added @int-index for #5679.
23Skidoo
on 11 Nov 2018
Added @emilypi for #5755.
23Skidoo
on 1 Dec 2018
Added @hrhino for #5810.
23Skidoo
on 15 Jan 2019
I can't believe i missed my own commit bits! Thanks! also, great job @hrhino!
emilypi
on 16 Jan 2019
Added @earldouglas for #5879 and #5878.
23Skidoo
on 14 Feb 2019
Added @tseenshe for #5906.
23Skidoo
on 3 Mar 2019
Added @piyush-kurur for #5514.
23Skidoo
on 3 Mar 2019
Added @sboosali for #5928.
23Skidoo
on 10 Mar 2019
Added @JoshMeredith for his contributions to #5995.
23Skidoo
on 26 Apr 2019
Added @basvandijk for past contributions.
23Skidoo
on 26 Apr 2019
@23Skidoo can we add @fendor for #6078 and #5954, part of which got merged as #6108?
DanielG
on 11 Oct 2019
Added @fendor.
23Skidoo
on 11 Oct 2019
Related issues
phadej
·
3Comments
nomeata
·
4Comments
menelaos
·
3Comments
nomeata
·
4Comments
nh2
·
3Comments
Most helpful comment
Added @emilypi for #5755.