C-toxcore: Fix automatic bitrate management in ToxAV
In 2015 the new ToxAV API had been merged.
Among other things, the introduced bitrate management hasn't really worked well.
Because of that, it had been disabled in qTox: https://github.com/qTox/qTox/commit/db52ef6e6a843faa8543b4726a5c281b8f1e1d97
@tux3 wrote:
For some users on poor connections, toxav would suggest lower and lower bitratres until reaching zero and disabling audio/video entirely, toxav would then not raise the bitrate back and the only way to re-enable audio/video would have been to change A/V sources or restart the call
We now log toxav's recommendation, but ignore it
ovalseven8
All 2 comments
@mannol
alexeysvrv
on 6 Nov 2016
Client bitrate management is a distraction. Either toxav needs to hand a lot more than just bitrate management to the client, or it needs to take everything away. This is a case where I don't think you can hold your cake and eat it too.
GrayHatter
on 6 Nov 2016
Related issues
Geremia
路
4Comments
zetok
路
9Comments
zetok
路
3Comments
ovalseven8
路
11Comments
MrSorcus
路
10Comments
Most helpful comment
Client bitrate management is a distraction. Either toxav needs to hand a lot more than just bitrate management to the client, or it needs to take everything away. This is a case where I don't think you can hold your cake and eat it too.