Bulma: Column gap without default variable

Created on 5 Jun 2019  路  2Comments  路  Source: jgthms/bulma

https://github.com/jgthms/bulma/blob/01a1321e12a0cae265a5fa918c7ec5e77f74a879/sass/grid/columns.sass#L469

I was trying to change the gap for my columns by setting the $column-gap before Bulma import as documented. But the gap was not changing and I saw that part of the code.

Shouldn't that --columnGap be --columnGap: $column-gap or just use $column-gap instead of --columnGap???

customization stale

Most helpful comment

If something like this looks okay, I'll file a PR:

Screenshot 2019-06-06 19 19 42

...etc, etc, etc. I don't know exactly how wordy Bulma typically likes the variable names to be. (Or if that's even a good variable name, but it can easily be changed before I make a commit.)

edit: I'm realizing that I don't know enough about Sass/SCSS to know if that !default will cause issues there, so I'm going to hold off on filing anything for now until I can better understand what to do here. I thought this was a simple fix but I didn't notice that bit. I'm still learning all the complexities of all this!

edit2: Learned that it's not an issue, but I had to have it in #{ } brackets anyway. Still learning! Updated my screenshot.

All 2 comments

If something like this looks okay, I'll file a PR:

Screenshot 2019-06-06 19 19 42

...etc, etc, etc. I don't know exactly how wordy Bulma typically likes the variable names to be. (Or if that's even a good variable name, but it can easily be changed before I make a commit.)

edit: I'm realizing that I don't know enough about Sass/SCSS to know if that !default will cause issues there, so I'm going to hold off on filing anything for now until I can better understand what to do here. I thought this was a simple fix but I didn't notice that bit. I'm still learning all the complexities of all this!

edit2: Learned that it's not an issue, but I had to have it in #{ } brackets anyway. Still learning! Updated my screenshot.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

guillecro picture guillecro  路  3Comments

Wikiki picture Wikiki  路  3Comments

rogervila picture rogervila  路  3Comments

choonggg picture choonggg  路  3Comments

swamikevala picture swamikevala  路  3Comments