Buildkit: nit: rename `buildctl build --no-progress`

Created on 8 Jun 2018 · 6Comments · Source: moby/buildkit

--no-console? --classic ?

@tonistiigi @tiborvass

exbeginner

Source

AkihiroSuda

Most helpful comment

After some back and forth, docker cli went with --console=(auto,true,false). buildctl should probably replicate.

tonistiigi on 15 Jun 2018

👍2

All 6 comments

--no-console sgtm

tonistiigi on 8 Jun 2018

👍2

Fine with --no-console

tiborvass on 9 Jun 2018

👍1

After some back and forth, docker cli went with --console=(auto,true,false). buildctl should probably replicate.

tonistiigi on 15 Jun 2018

👍2

I could take a crack at this, @tonistiigi any pointers to the implementation of this for the docker cli so that we can match the automatic behavior?

DanielFallon on 19 Jun 2018

docker cli is in https://github.com/docker/cli/blob/master/cli/command/image/build_buildkit.go#L186-L190

tonistiigi on 19 Jun 2018

@tonistiigi @tiborvass I noticed this was somewhat related to my comments in cli - https://github.com/docker/cli/issues/1133
Personally, I found --no-progress more precise.