Buildinggadgets: Crash when pasting Mekanism/Thermal machines

[TheVekter]

IMPORTANT: Before continuing, please ensure that Building Gadgets (and any other mods involved) is updated to the latest available version

After deleting this template, please provide the following information:

• Forge version: 35.1.36
• Building Gadgets version: 3.7.3
• If the issue is a crash; An external link to the crash report: https://pastebin.com/JFDv6eAC
• How to reproduce the issue: I used the copy/paste gadget to copy a few Mekanism machines (injecting, crushing, smelting, purifying, and infusing factories) as well as the Thermal furnace and crusher. When pasting them the game showed the block animation for pasting, then locked up for 2 minutes before crashing to desktop.
• A screenshot, if applicable: N/A

EDIT: It's worth noting that I ended up having to open my world in Amulet and remove the pasted blocks - any attempt to load the world caused Minecraft to hard crash again.

[MajorTuvok]

Hmm, this originates again from the setBlockState also causing #578. The game calls for some reason remove on the Target block.

[MajorTuvok]

Without debugging into mc code, I guess this might be caused by attempting to add a new ticking TileEntity when a TileEntity is being ticked, aka into the same list whilst it is being iterated.

Could someone try without all the other mods, as a mod like Performant might very well have removed a copy of the ticking TileEntity loop, which would solve this Problem on Forge/MC's side. If that is not the case, we might have to go the very unpleasent way of replacing the EffectBlock in the next Pre-Tick event.

[wroof]

Just had this happen with the latest Direwolf lets play when pasting a Mekanism Waste Barrel onto a Empty Ultimate Pressurized Tube

[TheVekter]

Just had this happen with the latest Direwolf lets play when pasting a Mekanism Waste Barrel onto a Empty Ultimate Pressurized Tube

Worth noting that the waste barrels should be blacklisted from the C/P gadget, since you're not supposed to be able to move them without breaking them.

[MajorTuvok]

Worth noting that the waste barrels should be blacklisted from the C/P gadget, since you're not supposed to be able to move them without breaking them.

The C/P Gadget does not move them, you're building a new set of waste barrels. So I kind of don't agree

[wroof]

On a side note, although the game crashes after paste, the world is not corrupted and can simply be reloaded with the new barrel in place and working. When I used it again to place 5 barrels, it required 5 restarts to solve with each one logging a different barrel as the cause of failure.

[MajorTuvok]

Interesting, thanks for the note

[DizzyDJW]

On a side note, although the game crashes after paste, the world is not corrupted and can simply be reloaded with the new barrel in place and working. When I used it again to place 5 barrels, it required 5 restarts to solve with each one logging a different barrel as the cause of failure.

^This is why I can't open my world without a crash. I placed a 7x7 area of waste barrels. What's the soon-to-be fix for this? Like I said can't open my world without instant crash.

[MajorTuvok]

the soon-to-be fix for this

Please be patient, we do not have a lot of time, though If you find the time to implement a PR be our guest :)
Besides, I'm unsure if there is much BG can do about it (besides catching an exception and refusing to place the block).

can't open my world without instant crash

You can either open it 49 times in a row. Alternatively, it might work to remove bg (and accept to loose template items+gadgets) and allow Forge to remove the effect blocks. (After that you can re-add bg and you should be fine again)

[TheVekter]

On a side note, although the game crashes after paste, the world is not corrupted and can simply be reloaded with the new barrel in place and working. When I used it again to place 5 barrels, it required 5 restarts to solve with each one logging a different barrel as the cause of failure.

^This is why I can't open my world without a crash. I placed a 7x7 area of waste barrels. What's the soon-to-be fix for this? Like I said can't open my world without instant crash.

If you can load the world up in Amulet, you can remove the bugged blocks. You'll lose them (of course) but you can always cheat them back in.

[MajorTuvok]

Thanks for the help @TheVekter :)

[DizzyDJW]

You can either open it 49 times in a row. Alternatively, it might work to remove bg (and accept to loose template items+gadgets) and allow Forge to remove the effect blocks. (After that you can re-add bg and you should be fine again)

Honestly? This (besides catching an exception and refusing to place the block) would probably help tons especially if it stops the game from crashing to desktop over something so minor. There have been no "Crash to Main Menu" mods updated for 1.16.5 yet. Would love to see mods like that become a staple in _every_ modpack though.

If you can load the world up in Amulet, you can remove the bugged blocks. You'll lose them (of course) but you can always cheat them back in.

Will attempt this thanks

[DizzyDJW]

So just to note it's _VERY_ dangerous altering any Mekanism blocks in Amulet. It only affects the chunk you edited _HOWEVER_ it does break all modded blocks in those chunks. All my pipes became individual pipes without connecting to each other and I had to replace my entire fission reactor in order to get the GUI to pop up again. Not to mention all my waste barrels had become empty as well. Almost as if it reset all blocks to default or something without NBT tags or something.

[JDLENL]

same crash: https://paste.ee/p/AQvTF